Skip to content

Audit Intro & What is libp2p#176

Merged
salmad3 merged 7 commits intomasterfrom
audit/intro-and-more
Sep 7, 2022
Merged

Audit Intro & What is libp2p#176
salmad3 merged 7 commits intomasterfrom
audit/intro-and-more

Conversation

@salmad3
Copy link
Copy Markdown
Contributor

@salmad3 salmad3 commented Sep 1, 2022 •
edited
Loading

Context

  • Getting started style doc for libp2p and combined with intro
  • Moves index material on the intro doc to their own sections
  • Concepts -> Core components

Part of <--to open auditing issue-->

Latest preview

Please view the latest Fleek preview here

@salmad3 salmad3 added the ready for review PR is ready for review label Sep 1, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 1, 2022 •
edited
Loading

✅ Deploy Preview for libp2p-docs-mirror ready!

Name Link
🔨 Latest commit ebacc30
🔍 Latest deploy log https://app.netlify.com/sites/libp2p-docs-mirror/deploys/631845b13fa4e400084a4c43
😎 Deploy Preview https://deploy-preview-176--libp2p-docs-mirror.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

marten-seemann
marten-seemann reviewed Sep 6, 2022
View reviewed changes
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
salmad3 and others added 2 commits September 6, 2022 04:52
@salmad3
address PR feedback
099c625
@salmad3 @marten-seemann
Apply suggestions from code review
f8e76cd 
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
Copy link
Copy Markdown
Contributor Author

salmad3 commented Sep 6, 2022 •
edited
Loading

thanks @marten-seemann, addressed suggestions

@salmad3 salmad3 mentioned this pull request Sep 6, 2022
Closed
marten-seemann
marten-seemann reviewed Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @DannyS03! Just a few small things, then this should be good to go.

Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md Outdated
Comment thread content/introduction/_index.md
salmad3 and others added 2 commits September 7, 2022 03:13
@salmad3 @marten-seemann
Apply suggestions from code review
f022560 
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3
clarify transports
ebacc30
marten-seemann
marten-seemann approved these changes Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @DannyS03!

@salmad3 salmad3 removed the ready for review PR is ready for review label Sep 7, 2022
@salmad3 salmad3 merged commit 8f03731 into master Sep 7, 2022
@salmad3 salmad3 deleted the audit/intro-and-more branch January 3, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@mxinden mxinden Awaiting requested review from mxinden

Assignees

No one assigned

Labels

None yet

Projects

go-libp2p
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@salmad3 @marten-seemann