feat：Build an IDX file generator and wraps a PackEncoder to provide both pack and idx file generation functionality.#45
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses build environment compatibility issues encountered on Windows, particularly related to Buck2 build system configuration. The changes primarily focus on updating path separators in BUCK build files to use Windows-style backslashes and updating various dependency versions to resolve yanked packages and version conflicts.
Key changes:
- Updated path separators from Unix-style
/to Windows-style\\in BUCK build configuration files - Downgraded flate2 from 1.1.7 to 1.1.5 to avoid yanked version
- Updated various Rust dependency versions (log, syn, derive_more, etc.) to resolve compatibility issues
Reviewed changes
Copilot reviewed 299 out of 420 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| third-party/rust/crates/*/BUCK | Changed crate_root paths from forward slashes to backslashes for Windows compatibility |
| third-party/rust/crates/flate2/1.1.5/BUCK | Downgraded from yanked version 1.1.7 to stable 1.1.5 |
| src/protocol/*.rs | Applied clippy suggestions to use inline format strings |
| Capability::AllowTipSha1InWant => write!(f, "allow-tip-sha1-in-want"), | ||
| Capability::AllowReachableSha1InWant => write!(f, "allow-reachable-sha1-in-want"), | ||
| Capability::PushCert(value) => write!(f, "push-cert={}", value), | ||
| Capability::PushCert(value) => write!(f, "push-cert={value}"), |
There was a problem hiding this comment.
[nitpick] These format string changes are Rust 2021 edition improvements that eliminate the need for numbered placeholders. While these are good style improvements, they are unrelated to the PR's stated purpose of 'building an IDX file generator'. Consider separating formatting/style changes into a dedicated PR to maintain clear change history.
| name = "backtrace", | ||
| srcs = [":backtrace-vendor"], | ||
| crate = "backtrace", | ||
| crate_root = "vendor/src\\lib.rs", |
There was a problem hiding this comment.
@pleasedontbreak123 ， 在这里还是有路径问题，需要检查所有的新加 BUCK 文件
…oth pack and idx file generation functionality. (libra-tools#45) * before changes in encoding * complete build idx * fix clippy * fix buck * fix buck * fix * fix buck * fix buck （at least buck BUILD SUCCEEDED in my env.it's troublesome） * fix buck （at least buck BUILD SUCCEEDED in my env.it's troublesome） * fix buck * fix buck * rerun migrate
This PR adds a feature to generate Git pack and index files by creating an IDX file generator that encapsulates the PackEncoder, allowing seamless creation of both pack and idx files.
link #29
In my environment, I encountered an error because flate 1.1.7 was yanked, so I downgraded it.
and I encountered a lot error in buck building(flate , wasm,windows).At last it buid success at my env,but i can't figure it all out
;(