fix(upgrade): restore Windows release build - #444
Merged
genedna merged 1 commit intoJul 28, 2026
Conversation
Signed-off-by: Luxian <lux1an@qq.com>
Ivanbeethoven
marked this pull request as ready for review
July 27, 2026 07:43
genedna
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InstallDirAPI surface with fail-closed unsupported-platform errors, allowing Windows callers to compile without enabling Unix fd-relative upgrade operationsRoot Cause
The upgrade marker, transaction, and orchestrator modules compile on Windows, but
InstallDirexposed onlyopen_validatedthere. Their remaining method calls therefore failed with missing-method errors. Agent import also movedrootinto a Windows-only binding before a later borrow.Impact
Windows release builds now compile and retain the intended fail-closed behavior: auto-upgrade file operations remain unsupported outside Unix rather than falling back to path-based filesystem access.
Validation
cargo +1.97.1-x86_64-pc-windows-msvc build --locked --release --features keyring --target x86_64-pc-windows-msvcwith the release workflowRUSTFLAGStarget\\x86_64-pc-windows-msvc\\release\\libra.exe --versioncargo +1.97.1-x86_64-pc-windows-msvc build --locked --all-featurescargo +nightly fmt --all --checkpnpm --dir web lintpnpm --dir web buildcargo test --allwas also attempted on Windows. It is currently blocked by pre-existing Unix-only test code compiled without platform guards inopencode_export.rsandutils/object.rs; this is independent of this change and the release target builds successfully.