Skip to content

fix tty mode#27

Merged
mohanson merged 2 commits into
libraries:masterfrom
yazgoo:fix-tty-mode
Jul 20, 2020
Merged

fix tty mode#27
mohanson merged 2 commits into
libraries:masterfrom
yazgoo:fix-tty-mode

Conversation

@yazgoo

@yazgoo yazgoo commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

For tty mode, this fixes the following issues after the refactoring

  1. adds optional sound
  2. enable raw-mode to support keys

@yazgoo yazgoo mentioned this pull request Jul 17, 2020
@mohanson

Copy link
Copy Markdown
Collaborator

You turned on the audio in the tty, but the reason why I turned off the audio is that I want to be able to compile and run the emulator normally without an audio device (for example, via ssh), what do you think?

@yazgoo

yazgoo commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

Hi, SSH will still work with this since audio is disabled by default.
My feeling is that the functionality will still be usefull in other cases.

@mohanson

mohanson commented Jul 20, 2020

Copy link
Copy Markdown
Collaborator

On computers without audio equipment (such as Linux server), cpal cannot be compiled. I hope to support this by adding tty mode. This requires audio to be disabled.

@yazgoo

yazgoo commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

👌, Here is a proposal (see adding audio feature commit):

add an "audio" flag, enabled by default.
If one wants tty without audio, compile with:
--no-default-features --features tty
I one wants tty with audio, compile with:
--no-default-features --features tty,audio

@mohanson

Copy link
Copy Markdown
Collaborator

Great!

@mohanson mohanson merged commit 0908553 into libraries:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants