You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You turned on the audio in the tty, but the reason why I turned off the audio is that I want to be able to compile and run the emulator normally without an audio device (for example, via ssh), what do you think?
On computers without audio equipment (such as Linux server), cpal cannot be compiled. I hope to support this by adding tty mode. This requires audio to be disabled.
👌, Here is a proposal (see adding audio feature commit):
add an "audio" flag, enabled by default.
If one wants tty without audio, compile with: --no-default-features --features tty
I one wants tty with audio, compile with: --no-default-features --features tty,audio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tty mode, this fixes the following issues after the refactoring