fix(pages): include hidden files so .well-known is deployed - #34
Merged
Conversation
The deploy workflow's upload-pages-artifact step tars ./dist with --exclude=.[^/]* unless include-hidden-files is set, so public/.well-known never reached GitHub Pages. security.txt has been returning 404 in production since it was added, which also broke its own Canonical field. Also adds the Flathub website verification file requested on the org.libredb.Studio submission (flathub/flathub#9538). Tokens are appended once Flathub issues them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/upload-pages-artifacttars./distwith--exclude=.[^/]*unlessinclude-hidden-filesis set, sopublic/.well-known/never reached GitHub Pages.security.txthas been returning 404 in production since it was added, which also broke theCanonicalfield it declares.Changes:
deploy.yml: setinclude-hidden-files: trueon the upload step.public/.well-known/org.flathub.VerifiedApps.txt, the domain verification file requested on theorg.libredb.StudioFlathub submission (Add org.libredb.Studio flathub/flathub#9538). Lines starting with#are ignored by Flathub's parser; app tokens are appended once Flathub issues them.Verified locally:
bun run gateclean,bun run buildputs both files indist/.well-known/.Note:
deploy.ymlonly runs onrelease: publishedor manual dispatch, so this needs aworkflow_dispatchrun after merge to reach production.