Populate the alert rule field with the builder json - #14374
Merged
Conversation
That way it isn't empty. (which is unexpected)
PipoCanaja
reviewed
Sep 20, 2022
| $obj['alert_id'] = $alert['alert_id']; | ||
| $obj['severity'] = $alert['severity']; | ||
| $obj['rule'] = $alert['rule']; | ||
| $obj['rule'] = $alert['rule'] ?: json_encode($alert['builder']); |
Contributor
There was a problem hiding this comment.
do we keep $obj['builder'] = $alert['builder']; line 187 then ?
Member
Author
There was a problem hiding this comment.
@PipoCanaja yes, that is the array of the builder rule... not json. Other option is to remove the "rule" field completely, but since we haven't removed legacy rules (especially from the collection). It doesn't make much sense yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That way it isn't empty. (which is unexpected)
#14344
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.