fix: add PHP 8.2 compatibility attributes and signature fixes#4
Merged
paddatrapper merged 1 commit intolibretime:mainfrom Apr 17, 2026
Merged
fix: add PHP 8.2 compatibility attributes and signature fixes#4paddatrapper merged 1 commit intolibretime:mainfrom
paddatrapper merged 1 commit intolibretime:mainfrom
Conversation
- Add #[\ReturnTypeWillChange] to interface method overrides across 14 files
- Add #[\AllowDynamicProperties] to classes with dynamic properties
- Fix PropelPDO::query() signature for PHP 8 PDO compatibility
- Replace call_user_func_array('parent::query') with parent::query(...\$args)"
paddatrapper
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PHP 8.2 compatibility fixes to Propel1:
Add #[\ReturnTypeWillChange] to all methods overriding PHP built-in interfaces (Iterator, Countable, ArrayAccess, IteratorAggregate, RecursiveIterator)
Add #[\AllowDynamicProperties] to classes with dynamic properties
Fix PropelPDO::query() signature to match PHP 8's PDO interface
Replace deprecated call_user_func_array('parent::query', $args) with parent::query(...$args)