Video settings not saving properly between core and game overrides in some cases.

[bslenul]

Description

If you change video settings then make a core override and finally make a game override with the same video settings as in retroarch.cfg the game override will use settings from the core override!

Kinda confusing for me to explain clearly, so here's an example:

• I have Core Provided aspect ratio for global setting (so in retroarch.cfg I have aspect_ratio_index = "21").
• I want FCEUmm core to use 1:1 so I make a core override (aspect_ratio_index = "20" in FCEUmm.cfg).
• I want Batman to be displayed in Core Provided so I make a game override.
• BUT since it's the same value as the one in retroarch.cfg, the Batman.cfg is empty... So next time I'll start Batman, RetroArch will check the core override and think it's the setting to use!

And this is also true for Scale Integer, Force-disable sRGB FBO, etc.

Expected behavior

Force the changes to write in the game override if the value is different from the core override.

So in my example above it should write aspect_ratio_index = "21" in Batman.cfg.

Actual behavior

If the value in the game override and retroarch settings are identical nothing is written in the game override file.

Steps to reproduce the bug

1. Start RetroArch and go to Settings > Video, memorize your default aspect ratio.
2. Start a game, go to Settings > Video and change the aspect ratio to something different than step 1.
3. Go to Quick Menu and click Save **Core** Overrides.
4. Go back to Settings > Video, change the aspect ratio to the one from step 1.
5. Go to Quick Menu and click Save **Game** Overrides.
6. Close content, re-open your game, go to Settings > Video and you should see the aspect ratio from step 2 instead of the one from step 4.

Version/Commit

• RetroArch: 1.7.2 / 248f124 (tested on W10) and 1.7.2 / 037c47e (tested on Linux Mint).

Environment information

• OS: Windows 10 and Linux Mint, both 64bits.

[andres-asm]

I haven't confirmed this.

Could be due to this commit:
#6375

Or maybe it never worked, only stuff that is saved/loaded directly in configuration.c is overridable. @twinaphex doesn't like pointer grabbing from the drivers or something like that so some video settings load directly from the driver and those can't be overridable in that case.

[bslenul]

Thanks for the reply.

Could be due to this commit:
#6375

I don't think so, my Integer Scale issue is older than this commit. So yeah maybe it never worked, not sure tbh.

I think it's a pretty rare situation so it shouldnt be a big deal but I was really confused at first on why my settings kept resetting 🤔

[macedd]

up