If a core override configuration is being used, Retroarch will not save changes made in "Input" in the global settings.

[klaritan]

Description

If a core override configuration is being used, Retroarch will not save changes made in "Input" in the global settings.
This is "input" from the global menu, and not from Quick Menu

Expected behavior

Retroarch should either

1. Save Input settings to the core specific config [Preferred and expected behavior], or
2. Simply apply the changes made in the settings to the global setting.

Actual behavior

It is completely omitting the changes made even though save configuration on exit is set to "ON".

Steps to reproduce the bug

1. Load a game
2. Change input settings in the Settings > Input (change a button of the controller being used)
3. Exit Retroarch.
4. Load the same game with the same core. Changes are gone.

Bisect Results

Not sure when this started happening, but this is an old but that was mentioned in a few communities.

Here's a 5-month old post about it: https://www.reddit.com/r/miniSNESmods/comments/8brcsb/release_new_hakchi_retroarch_neo_172a_loads_of/dx9jstt/

Version/Commit

Build: Sept 12 2018 [7428fef]

Environment information

• OS: Windows 10 64bit

[andres-asm]

It's normal?
When overrides are enabled nothing from settings is saved in the main config, that's the main nature of the feature.

[klaritan]

It's normal?
When overrides are enabled nothing from settings is saved in the main config, that's the main nature of the feature.

No, it's not normal.
When the overrides are enabled, then it should be saved in the override config, but it doesn't.

The main nature of the feature should be changes being applied to the override, not just get thrown out.

It doesn't get saved anywhere. That's the problem.

[andres-asm]

It is normal, I wrote overrides.

will not save changes made in **"Input" in the global settings.**

So it's normal or... your issue is not worded correctly. Overrides are never autosaved. And it completely prevents config autosave.

While I can acknowledge there is a bug (overrides don't save input binds and a few other things due to limitations on the settings subsystem), the issue is either not worded correctly or you simply don't know how overrides work.

https://forums.libretro.com/t/config-overrides-remaps-and-presets/16236

[klaritan]

"overrides don't save input binds and a few other things due to limitations on the settings subsystem"

That is the problem here.

Are there any foreseeable changes incoming to the settings subsystem that can help fixing this bug?

[hizzlekizzle]

Input binds aren't really supposed to be saved in overrides. The remaps are meant to serve that role instead.

[klaritan]

Input binds aren't really supposed to be saved in overrides. The remaps are meant to serve that role instead.

I tried to use that as a workaround, but the problem with remaps is that it doesn't support some controllers very well.

For example, I have an official SNES controller connected to PC via an adapter. I can map the buttons perfectly fine with Input binds because you basically click on the button after selection a target button, but the remaps simply work differently.

For some reason, the remapping option displays "User #1: Xbox One Controller", under each button, but it's actually responding to my SNES controller. And my SNES controller (listed as User #3) has no option to change (All buttons just showing "---") down the list.
Also, the Start and Select buttons (button 9 & 10) of the SNES controller is not listed under the remapping option. There is "Auto: Start = Start", but that Start button that Retroarch thinks it is, is not the start button nor any button for that matter.

If "they aren't really supposed to be saved in overrides" (which is an odd and limiting thing to begin with), they should be saved in the global settings, then. The bug here is that they are not being saved in either of them, and remapping feature is buggy and not a suitable replacement for controller button rebinding.

[andres-asm]

It's not a limitation, I acknowledge it's a problem

For some reason, the remapping option displays "User #1: Xbox One Controller", under each button, but it's actually responding to my SNES controller. And my SNES controller (listed as User #3) has no option to change (All buttons just showing "---") down the list.

This means:

a. your pad is mapped incorrectly
b. your pad is using xinput mode

If you're using 8bitdo pads, use d-input mode instead.

[klaritan]

This means:

a. your pad is mapped incorrectly
b. your pad is using xinput mode

If you're using 8bitdo pads, use d-input mode instead.

I don't believe those are the reasons. I'll explain.

I've tested this with various pads (iBuffalo, official Nintendo + adapter, Elecom SNES controllers, etc.), but these don't have XInput mode, at all.

I'll take iBuffalo as an example. In the Settings > Input settings, For user #1, I set iBuffalo as 1 seen here: https://i.imgur.com/ukrqZQp.png

However, under the Quick Menu's remapping feature: it says it's an XInput controller (I have an XInput fight stick connected and recognized as Xinput index 0, but it is not being used).

https://i.imgur.com/MIcjXiR.png

When I use the fightstick (XInput index 0), the buttons don't work on RetroArch as it should be. I don't use this controller on RetroArch at all and it has been set to not use them (shown in the first screenshot). When I use the iBuffalo controller, the remapping works fine.

I think it's just a small display error, not whether it's remapped correctly or xinput mode.

None of the controllers I use on RetroArch are on XInput (SNES controllers, DualShock 4, etc.).

I do have another wireless 8bitdo pad, but that thing works fine. I don't use it on XInput mode since I'd like to keep those 4 indexes cleared for MAME (not RetroARch) and Steam games.

---

Anyhow, the bug I'm reporting for this issue entry is where Input binding not getting saved (either in the core override or the global), and simply getting omitted when there's an override being used.

[sonninnos]

I believe this can be closed since overrides save also input bind stuff now.

[hizzlekizzle]

I don't think OP's issue is resolved, per se, but I think it can be closed anyway as a "working as intended / wontfix"

[sonninnos]

Sure, I just went with the end note:

Anyhow, the bug I'm reporting for this issue entry is where Input binding not getting saved (either in the core override or the global), and simply getting omitted when there's an override being used.