Add option to find thumbnail images by playlist rom filename#15731
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Sep 26, 2023
bulzipke:master
Merged
Add option to find thumbnail images by playlist rom filename#15731LibretroAdmin merged 1 commit intolibretro:masterfrom bulzipke:master
LibretroAdmin merged 1 commit intolibretro:masterfrom
bulzipke:master
Conversation
Member
|
Tweaked some of the wording in #15741 . Thanks so much! |
JoeOsborn
pushed a commit
to JoeOsborn/RetroArch
that referenced
this pull request
Nov 2, 2023
AveyondFly
added a commit
to AveyondFly/RetroArch
that referenced
this pull request
Dec 20, 2023
In the commit [1], a global configuration "thumbnail match with filename" was added which allows thumbnail match with filename. This commit adds playlist level "thumbnail match with filename" for more flexible configuration. [1] 32ed9b6 ("플레이리스트 롬파일 이름으로 썸네일 이미지를 찾도록 옵션 추가 (libretro#15731)") Signed-off-by: masky2012 <msuanming@163.com>
AveyondFly
added a commit
to AveyondFly/RetroArch
that referenced
this pull request
Dec 20, 2023
In the commit [1], a global configuration "thumbnail match with filename" was added which allows thumbnail match with filename. This commit adds playlist level "thumbnail match with filename" for more flexible configuration. [1] 32ed9b6 ("플레이리스트 롬파일 이름으로 썸네일 이미지를 찾도록 옵션 추가 (libretro#15731)") Signed-off-by: masky2012 <msuanming@163.com>
AveyondFly
added a commit
to AveyondFly/RetroArch
that referenced
this pull request
Dec 20, 2023
In the commit [1], a global configuration "thumbnail match with filename" was added which allows thumbnail match with filename. This commit adds playlist level "thumbnail match with filename" for more flexible configuration. [1] 32ed9b6 ("플레이리스트 롬파일 이름으로 썸네일 이미지를 찾도록 옵션 추가 (libretro#15731)") Signed-off-by: masky2012 <msuanming@163.com>
This was referenced Dec 20, 2023
LibretroAdmin
pushed a commit
that referenced
this pull request
Dec 21, 2023
In the commit [1], a global configuration "thumbnail match with filename" was added which allows thumbnail match with filename. This commit adds playlist level "thumbnail match with filename" for more flexible configuration. [1] 32ed9b6 ("플레이리스트 롬파일 이름으로 썸네일 이미지를 찾도록 옵션 추가 (#15731)") Signed-off-by: masky2012 <msuanming@163.com>
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
In the commit [1], a global configuration "thumbnail match with filename" was added which allows thumbnail match with filename. This commit adds playlist level "thumbnail match with filename" for more flexible configuration. [1] 32ed9b6 ("플레이리스트 롬파일 이름으로 썸네일 이미지를 찾도록 옵션 추가 (libretro#15731)") Signed-off-by: masky2012 <msuanming@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many features, such as saves (SRM) and states, are stored by rom filename.
However, thumbnails are being saved by the label of the playlist, not the rom filename.
This is an inconsistent convention and requires additional management.
A related issue is that on platforms where certain charsets are not supported, users are forced to set the playlist's label to English for thumbnails. This option seems to solve that problem.
Related Issues
#7389
#13819