Silence warnings#17713
Merged
LibretroAdmin merged 4 commits intolibretro:masterfrom Mar 20, 2025
Merged
Conversation
One of the GCC14's optimization heuristic triggered here, suggesting that the special value of len (size_t) could potentially be lesser than the file's size (int64_t) but greater than "maximum object size" (set by byte-size, PTRDIFF_MAX by default). Use the same type as the file size it's compared to, and adjust the sentinel value to spell INT64_MAX.
At optimization level -O3, GCC generates a warning about its own optimizations, likely due to loop unrolling. Manually unroll the loop to eliminate any ambiguity and prevent the warning.
Import the change from upstream 16c83cd5fc4c18954c1b6e3de16c37ba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silence -Walloc-size-larger-than=byte-size
Silence GCC stringop-overflow
Silence warning: left shift of negative value
Silence a dangling-pointer warning in Lzma