Fix overlay lightgun, mouse & pointer#17752
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Apr 6, 2025
Merged
Conversation
- Ensure other touchscreen input is blocked when overlay buttons pressed - Limit physical+overlay mouse input to iOS for now - Reset overlay mouse deltas when there is no touch input - Disable touch mouse in android_input.c for now. Too buggy
Contributor
|
Let me know what you think after testing it @warmenhoven i also agree with the general idea to get this working on. Ore platforms than just ios. However, this could be done at our own leisure after merge |
Collaborator
|
My initial pass on iOS is done and this is feeling really good to me, across multiple cores and input methods. I think it's good to merge. Thank you very much! |
Contributor
|
@neil4 merged now. Sorry it took a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17699
Eventually the code behind
#ifdef IOScould be the norm if other touchscreen mice are tested to not interfere with the overlay mouse. For that, some input drivers might need to be updated to not create touchscreen mouse input at all when the overlay mouse is on.@warmenhoven Test on iOS when you can.