Revert "Use size_t for new_selection as done everywhere else"#17811
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Apr 16, 2025
Merged
Revert "Use size_t for new_selection as done everywhere else"#17811LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
At least `case MENU_ACTION_UP` compares new_selection against 0, the type needs to be signed. Revert 5710a7f now and revisit after a deeper look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least
case MENU_ACTION_UPcompares new_selection against 0, the type needs to be signed. Revert 5710a7f now and revisit after a deeper look.Reported in #17810