Revert "Define WIN32_LEAN_AND_MEAN to avoid collision with winsock2"#17821
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Apr 18, 2025
Merged
Revert "Define WIN32_LEAN_AND_MEAN to avoid collision with winsock2"#17821LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
The Windows builds have been missing some libraries, notably avdevice-58.dll, avfilter-7.dll, and prostproc-55.dll as reported by a user on Discord. I suspect it's caused by cc842fd, although I don't fully understand why that would happen.
Contributor
|
Alright, merged. Let me know if this resolves it after consulting with the user |
Collaborator
|
It didn't resolve it, there was a different issue with the packaging script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows builds have been missing some libraries, notably avdevice-58.dll, avfilter-7.dll, and postproc-55.dll as reported by a user on Discord. I suspect it's caused by cc842fd, although I don't fully understand why that would happen.