Fix a bug in the open() function in the Storage Access Framework VFS backend#18360
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Nov 5, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for the Storage Access Framework was added to the libretro-common VFS code in #18336, but the function for opening files in that VFS backend has a bug where if the file you're trying to open doesn't already exist, it is created if and only if
(mode & RETRO_VFS_FILE_ACCESS_WRITE) != 0(otherwise the file is not created and the function returns null).The actual correct behaviour that would be consistent with the other existing VFS backends is if the file doesn't exist, the file should be created if and only if
(mode & RETRO_VFS_FILE_ACCESS_WRITE) != 0 && (mode & RETRO_VFS_FILE_ACCESS_UPDATE_EXISTING) == 0is true, which I've corrected the function to do in this pull request.