Revert mipmap generation on render targets from 66a7657#18731
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Feb 14, 2026
Merged
Revert mipmap generation on render targets from 66a7657#18731LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
8849245 to
7d6f3db
Compare
Contributor
Author
|
Hi @hizzlekizzle this PR contains all the mip map generation changes reverted so that we can fix up the issues the original commit 66a7657 introduced. We can just work on that commit in a local branch to add support for tagging specific passes/render targets for mip map generation rather than this more blanket change. It should be noted I've kept an actual valid fix from 66a7657: while ((width > 1) || (height > 1)) to stop validation errors |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix mipmaps on generated textures) across D3D10, D3D11, and D3D12GENERATE_MIPS/MipLevels = 0on shader pass render targets and the associatedGenerateMips/d3d12_generate_mipmapscalls after render passes||vs&&loop condition) which is a valid standalone bugfixContext
The mipmap changes from 66a7657 were previously reverted in 226d7b1 (D3D12 only) and then partially re-merged in 7df941e alongside HDR pipeline fixes. This PR cleanly separates the two, reverting only the mipmap render target feature while keeping the HDR fixes intact.