Fix Run-Ahead/Preemptive Frames setting UI regression#18948
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Apr 17, 2026
Merged
Fix Run-Ahead/Preemptive Frames setting UI regression#18948LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After commit 5e46f0c, which turned most instances of
menu_displaylist_build_info_selective_t build_list[]tostatic, the Run-Ahead frames setting was not reacting properly anymore to the user-selected Run-Ahead mode.Namely, the "Number of Preemptive Frames" setting was being displayed next to the other options whenever switching to the Preemptive Frames mode, instead of dynamically replacing the normal Run-Ahead Frames setting in the menu.
This PR fixes the issue by tightening the conditions for the visibility of the Run-Ahead settings, so that the mutual appearance of the two options mentioned above is preserved while still retaining the
staticattribute.Related Issues
Fixes #18947.
Reviewers
@LibretroAdmin