Skip to content

[LIBNX] Threading changes, implement OpenGL support, Font fix#7303

Merged
inactive123 merged 4 commits into
libretro:masterfrom
m4xw:libnx_opengl
Sep 27, 2018
Merged

[LIBNX] Threading changes, implement OpenGL support, Font fix#7303
inactive123 merged 4 commits into
libretro:masterfrom
m4xw:libnx_opengl

Conversation

@m4xw
Copy link
Copy Markdown
Contributor

@m4xw m4xw commented Sep 26, 2018

Description

Added some changes to the switch_pthread wrapper:

  • Let the system schedule the threads across the first 3 cores

Implemented OpenGL support:

  • Currently there is a bug in mesa's switch-EGL backend that doesn't allow clean re-init
  • A workaround is to not terminate egl and just leak, but terminate it on platform de-init
  • Added Symbols/Headers to fully load GL (since we can't use <GL/gl.h>)
  • We need to check if we want to unify the glsym.py scripts, as they are all very simliar and make small changes for easier maintainability

Fix switch_font:

  • Just a oversight from the initial backport

Notes

Currently HAVE_OPENGL is off by default, as it break's video_threaded which is a requirement to get fullspeed on some cores (mostly pcsx).
Both GL and non-GL build are functioning.
I made a quick test with mupen64plus and it just works if glsym files are replaced (ignoring all non-relevant changes).

Reviewers

@twinaphex @Themaister

@inactive123
Copy link
Copy Markdown
Contributor

Looks good to me @m4xw. Just one question - is HAVE_XMB disabled deliberately when GL support is enabled? I would imagine that would be one of the nicer menu systems to use with GL support.

@m4xw
Copy link
Copy Markdown
Contributor Author

m4xw commented Sep 27, 2018

@twinaphex HAVE_XMB is disabled right now because that needs threaded data runloop set to false.
Then it works. Material doesn't have that problem so I just focus on that for now.
No problem with ozone either btw.
Another note: Seems there is a fix for my deinit problem on upstream, tho not on the packages for libnx yet.
I can check that this evening myself, we can either wait with this PR or I just remove that workaround later

@inactive123
Copy link
Copy Markdown
Contributor

I'm fine with merging this for now and then you just remove the workaround later. So let's do that.

@inactive123 inactive123 merged commit c4da97a into libretro:master Sep 27, 2018
@m4xw m4xw deleted the libnx_opengl branch September 27, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants