[LIBNX] Threading changes, implement OpenGL support, Font fix#7303
Merged
Conversation
Contributor
|
Looks good to me @m4xw. Just one question - is HAVE_XMB disabled deliberately when GL support is enabled? I would imagine that would be one of the nicer menu systems to use with GL support. |
Contributor
Author
|
@twinaphex HAVE_XMB is disabled right now because that needs threaded data runloop set to false. |
Contributor
|
I'm fine with merging this for now and then you just remove the workaround later. So let's do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added some changes to the switch_pthread wrapper:
Implemented OpenGL support:
Fix switch_font:
Notes
Currently HAVE_OPENGL is off by default, as it break's video_threaded which is a requirement to get fullspeed on some cores (mostly pcsx).
Both GL and non-GL build are functioning.
I made a quick test with mupen64plus and it
just worksif glsym files are replaced (ignoring all non-relevant changes).Reviewers
@twinaphex @Themaister