Issue #5838: OCR and translate screen feature#8738
Merged
inactive123 merged 1 commit intolibretro:masterfrom May 11, 2019
BarryJRowe:OCR_Translation
Merged
Issue #5838: OCR and translate screen feature#8738inactive123 merged 1 commit intolibretro:masterfrom BarryJRowe:OCR_Translation
inactive123 merged 1 commit intolibretro:masterfrom
BarryJRowe:OCR_Translation
Conversation
BarryJRowe
changed the title
Contributor
Author
|
The fix for non-standard ports in urls is no longer working. I'll work on it and update the PR. Edit: non-standard ports are working again. Just working with the automated checks now. |
BarryJRowe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for the OCR issue. Adds an additional config option to set a translation service url to use when the user pauses the game. When the server returns, it updates the screen with the translated text. A compatible service that can be used to translate game screens is located here: https://gitlab.com/spherebeaker/vgtranslate which takes either a google cloud vision key + google translate key OR an installed tesseract + google translate key. You can run this locally and point to it in your configuration, or point to one that someone else has set up.
Remaining issues:
1.) In hardware mode you can't get the video_frame_cache as suggested in the issue, but you can get the viewport. What to then do with a translated viewport, I'm not so sure.
2.) There's a bug in the SSE2 path of the pixel converter need for the X8888 core case. It was suggested that I make a different issue for this, so I'll submit that soon.