Skip to content

Qt: fix file browser resorting#8966

Open
CozmoP wants to merge 2 commits intolibretro:masterfrom
CozmoP:sort
Open

Qt: fix file browser resorting#8966
CozmoP wants to merge 2 commits intolibretro:masterfrom
CozmoP:sort

Conversation

@CozmoP
Copy link
Copy Markdown
Contributor

@CozmoP CozmoP commented Jun 13, 2019

This fixes a bug @retro-wertz reported on Discord in which the table view of the file browser is sorted by name upon launching compressed content.
Appears to be an issue with QTableView, since just changing it for a QTreeView solves it.
So I did that for both the file browser and content browser to keep them consistent.
It looks a bit diferent, there are no grid lines and the rows are a bit shorter.
I think it looks better but I welcome @bparker06 @Tatsuya79 and others' input.

@orbea
Copy link
Copy Markdown
Contributor

orbea commented Jun 13, 2019

Do you happen to have any before and after screenshots?

@Tatsuya79
Copy link
Copy Markdown
Contributor

Tatsuya79 commented Jun 13, 2019

It changes from this
Untitled-1

to this
Untitled-2

I don't really like losing the vertical separation and some columns are too close to each other.
It's hard to see where to move the pointer to get the resize cursor.

But the main issue is that the column sizes aren't recovered properly after restarting RA a couple of times.
You can see the horizontal scroll bar on the bottom of the 2nd pic: I can not get rid of it.
There's always a blank space on the right you can't resize any more.
(I tried removing the qt cfg file)

I'm on win7 x64 and I didn't have that issue when launching a zip rom: if I had the lines sorted by size it would stay on that after the game was started.

@RobLoach
Copy link
Copy Markdown
Member

I like the change. Seems to be better aligned more with other lists I see on my desktop.

@inactive123
Copy link
Copy Markdown
Contributor

OK have some of @Tatsuya79's concerns been addressed?

@ghost
Copy link
Copy Markdown

ghost commented Jun 19, 2019

im ok with the sorting so far. if alignment is gonna be changed as requested, is it possible to also adjust so that there is a little space between the romname/title and the left-most of its box.

@inactive123
Copy link
Copy Markdown
Contributor

inactive123 commented Jun 20, 2019

@CozmoP

'I don't really like losing the vertical separation and some columns are too close to each other.'

Can there be an option for being able to turn this on/off? I think that could address one of @Tatsuya79 's criticisms.

@ghost
Copy link
Copy Markdown

ghost commented Jul 12, 2019

I agree with @Tatsuya79, I like the old screenshot better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants