Replace union with struct in audio_mixer_voice#192
Merged
inactive123 merged 1 commit intolibretro:masterfrom Apr 5, 2022
Merged
Replace union with struct in audio_mixer_voice#192inactive123 merged 1 commit intolibretro:masterfrom
inactive123 merged 1 commit intolibretro:masterfrom
Conversation
audio_mixer_play_ogg calls stb_vorbis_close if types.ogg.stream is set but it overlaps with wav.position and stb_vorbis_close ends up freeing unallocated space and crashing Space saving is minor, so let's just split the variants
Contributor
Author
|
@twinaphex |
Member
|
@phcoder Thanks for the investigation here! Was wondering what was causing that to happen 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
audio_mixer_play_ogg calls stb_vorbis_close if types.ogg.stream is set
but it overlaps with wav.position and stb_vorbis_close ends up freeing
unallocated space and crashing
Space saving is minor, so let's just split the variants