Allow building static libs#183
Merged
hobu merged 1 commit intolibspatialindex:masterfrom Mar 28, 2020
Merged
Conversation
Contributor
Author
|
I'll force push another commit because SIDX_DLL and SIDX_C_DLL need refactoring (msvc with MTd and static lib is broken without those modifications). |
hobu
approved these changes
Mar 28, 2020
Member
|
Can you please add a build scenario to the Azure pipelines that exercise a static build? It doesn't need to be part of this PR, but it is likely to rot otherwise. |
Member
|
I implemented cmake targets exports in #186 which I think you could use to implement GenerateExportHeader as well. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #177