Fix C API for Visual Studio#184
Merged
hobu merged 1 commit intolibspatialindex:masterfrom Apr 24, 2020
Merged
Conversation
cinttypes was included, but it's a C++ header. Instead, stdint.h is included for Visual Studio 2010+
Member
|
Can you provide more detail why this change was needed? |
mortymacs
reviewed
Mar 28, 2020
| #if _MSC_VER >= 1900 | ||
| #include <cinttypes> | ||
| #else | ||
| #include <stdint.h> |
Contributor
Author
There was a problem hiding this comment.
cstdint is a C++ header. Why do you want to include a C++ header in a C API?
Contributor
Author
|
Because cinttypes is a C++ header, therefore a pure C program will fail to compile with msvc. And this is also why cstdint must not be included in a C API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #179