channel: fix comment about handling of trailing zero byte#1781
Merged
willco007 merged 2 commits intolibssh2:masterfrom Apr 6, 2026
Conversation
vszakats
approved these changes
Jan 15, 2026
vszakats
changed the title
There was a problem hiding this comment.
Pull request overview
This PR corrects a comment and removes unnecessary buffer allocation in the X11 forwarding cookie generation code. The original comment incorrectly described the handling of the trailing null byte from sprintf operations, and the buffer was over-allocated by 1 byte.
Changes:
- Updated the comment to accurately describe that snprintf() writes the trailing null byte after the LIBSSH2_X11_RANDOM_COOKIE_LEN boundary in the output buffer
s, which is safe becauseshas 4 extra bytes allocated for the screen_number - Removed the unnecessary
+ 1from the buffer array size declaration since the local buffer is only used as input and doesn't need space for null termination
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willco007
pushed a commit
to willco007/libssh2
that referenced
this pull request
Apr 7, 2026
…1781) Notes: Removed the unnecessary + 1 from the buffer array size declaration since the local buffer is only used as input and doesn't need space for null termination. Credit: Lars Nordin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.