tidy-up: miscellaneous#1842
Closed
vszakats wants to merge 5 commits intolibssh2:masterfrom
Closed
Conversation
libssh2 does not create this and it's not libssh2-specific. The best place for this is the global .gitignore on the local macOS machine. Follow-up to 2b71623 libssh2#1803 Follow-up to 4f9e6e0 libssh2#1718
Member
|
Please don't remove.ds_store from git ignore. |
Member
Author
Can you add it to your local |
Member
|
It's fine, I'll do that. I'd prefer if libssh2 had 'logical defaults' out of the box however. |
Member
Author
|
That may be a PR for Git itself, fixing it for all repos. (Not even dreaming Apple fixing this in addition.) Thanks for fixing locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.DS_Store(again)Keep this list for files created by libssh2. For other files, the
per-machine global Git ignore file is a better place, and it fixes
this for all repos, not just libssh2.
https://github.com/libssh2/libssh2/pull/1842/files?w=1