Error: operand size mismatch for `movq'

[malaterre]

tomcrypt does not build on x32, as seen at:

http://buildd.debian-ports.org/status/fetch.php?pkg=libtomcrypt&arch=x32&ver=1.17-3.2&stamp=1361157947

libtool: compile: gcc -c -I./src/headers/ -Wall -Wsign-compare -W -Wshadow -DLTC_SOURCE -O3 -funroll-loops -fomit-frame-pointer -c src/encauth/gcm/gcm_gf_mult.c -fPIC -DPIC -o src/encauth/gcm/.libs/gcm_gf_mult.o
src/encauth/gcm/gcm_gf_mult.c: Assembler messages:
src/encauth/gcm/gcm_gf_mult.c:134: Error: operand size mismatch for movq' src/encauth/gcm/gcm_gf_mult.c:135: Error: incorrect register%eax' used with q' suffix src/encauth/gcm/gcm_gf_mult.c:134: Error: operand type mismatch formovq'
src/encauth/gcm/gcm_gf_mult.c:135: Error: incorrect register %r11d' used withq' suffix
src/encauth/gcm/gcm_gf_mult.c:198: Error: incorrect register %r9d' used withq' suffix
src/encauth/gcm/gcm_gf_mult.c:199: Error: operand type mismatch for movq' src/encauth/gcm/gcm_gf_mult.c:200: Error: incorrect register%r9d' used with q' suffix src/encauth/gcm/gcm_gf_mult.c:198: Error: incorrect register%edx' used with q' suffix src/encauth/gcm/gcm_gf_mult.c:199: Error: operand type mismatch formovq'
src/encauth/gcm/gcm_gf_mult.c:200: Error: incorrect register %edx' used withq' suffix
src/encauth/gcm/gcm_gf_mult.c:198: Error: incorrect register %edi' used withq' suffix
src/encauth/gcm/gcm_gf_mult.c:199: Error: operand type mismatch for movq' src/encauth/gcm/gcm_gf_mult.c:200: Error: incorrect register%edi' used with q' suffix src/encauth/gcm/gcm_gf_mult.c:198: Error: incorrect register%ecx' used with q' suffix src/encauth/gcm/gcm_gf_mult.c:199: Error: operand type mismatch formovq'
src/encauth/gcm/gcm_gf_mult.c:200: Error: incorrect register %ecx' used withq' suffix
make[1]: *** [src/encauth/gcm/gcm_gf_mult.o] Error 1
make[1]: Leaving directory `/build/buildd-libtomcrypt_1.17-3.2-x32-uQH4LL/libtomcrypt-1.17'

[rofl0r]

seems this #ifdef here is to blame https://github.com/libtom/libtomcrypt/blob/master/src/headers/tomcrypt_macros.h#L101

can you paste output of your compiler when invoked as gcc -E -dM - < /dev/null please ?

[sjaeckel]

It seems a similar issue has already been addressed in dropbear https://bugzilla.yoctoproject.org/show_bug.cgi?id=4496

[rofl0r]

looks like changing https://github.com/libtom/libtomcrypt/blob/master/src/headers/tomcrypt_cfg.h#L77 from usigned long to unsigned long long would work then.
@malaterre could you test if that fixes the issue ?

[sjaeckel]

I'm currently working on it... it's not that easy...

[sjaeckel]

I've pushed fix/x32 branches for ltc and ltm

to build and verify basically working ltm

1. make -j3 test mtest to build ltm native for your architecture
2. copy mtest/mtest to some folder that will not be cleaned
3. run mtest vs. test ./path/to/mtest/mtest | ./test to make sure mtest works
4. make clean && CC="gcc -mx32" make -j3 test
5. run native mtest vs x32 test to make sure your x32 build worksstill

ltc testme
CC="gcc -mx32" ./testme.sh "makefile -j3" "-DUSE_LTM -DLTM_DESC -DLTC_ECC_TEST_DBG -I../libtommath" ../libtommath/libtommath.a

The issue is not fixed, as ecc tests are still failing.

[malaterre]

patch has been integrated in debian: http://packages.qa.debian.org/libt/libtomcrypt/news/20140102T064828Z.html
thanks