Skip to content

RC4 PRNG - broken import/export #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karel-m wants to merge 3 commits into from
Closed

RC4 PRNG - broken import/export #178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adf7f1e
RC4 PRNG - broken import/export
karel-m Mar 26, 2017
5d174f8
tuning prng tests
karel-m Mar 27, 2017
cb8c905
tuning prng tests
karel-m Mar 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions testprof/cipher_hash_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

int cipher_hash_test(void)
{
int x;
int x, fails = 0;
unsigned char buf[4096];
unsigned long n;
prng_state nprng;
Expand All @@ -21,21 +21,39 @@ int cipher_hash_test(void)

/* test prngs (test, import/export */
for (x = 0; prng_descriptor[x].name != NULL; x++) {
unsigned char buf1[100], buf2[100];

DOX(prng_descriptor[x].test(), prng_descriptor[x].name);
DOX(prng_descriptor[x].start(&nprng), prng_descriptor[x].name);
DOX(prng_descriptor[x].add_entropy((unsigned char *)"helloworld12", 12, &nprng), prng_descriptor[x].name);
DOX(prng_descriptor[x].ready(&nprng), prng_descriptor[x].name);
n = sizeof(buf);
DOX(prng_descriptor[x].pexport(buf, &n, &nprng), prng_descriptor[x].name);
if (prng_descriptor[x].read(buf1, 100, &nprng) != 100) exit(EXIT_FAILURE); /* skip 100 bytes */
if (prng_descriptor[x].read(buf1, 10, &nprng) != 10) exit(EXIT_FAILURE); /* 10 bytes for comparison */
prng_descriptor[x].done(&nprng);

DOX(prng_descriptor[x].pimport(buf, n, &nprng), prng_descriptor[x].name);
DOX(prng_descriptor[x].ready(&nprng), prng_descriptor[x].name);
if (prng_descriptor[x].read(buf, 100, &nprng) != 100) {
fprintf(stderr, "Error reading from imported PRNG!\n");
exit(EXIT_FAILURE);
}
/*DOX(prng_descriptor[x].ready(&nprng), prng_descriptor[x].name);*/ /* it fails both with/without this line */
if (prng_descriptor[x].read(buf2, 100, &nprng) != 100) exit(EXIT_FAILURE); /* skip 100 bytes */
if (prng_descriptor[x].read(buf2, 10, &nprng) != 10) exit(EXIT_FAILURE); /* 10 bytes for comparison */
prng_descriptor[x].done(&nprng);

if (XMEMCMP(buf1, buf2, 10) != 0) {
int i;
fprintf(stderr, "%s export/import FAILED\n", prng_descriptor[x].name);
fprintf(stderr, "%s buf1: ", prng_descriptor[x].name);
for(i = 1; i < 10; i++) fprintf(stderr, "%02x ", buf1[i]);
fprintf(stderr, "\n%s buf2: ", prng_descriptor[x].name);
for(i = 1; i < 10; i++) fprintf(stderr, "%02x ", buf2[i]);
fprintf(stderr, "\n");
fails++;
}
else {
fprintf(stderr, "%s export/import OK\n", prng_descriptor[x].name);
}
}
if (fails > 0) return CRYPT_FAIL_TESTVECTOR;

return 0;
}
Expand Down