Conversation
Member
sjaeckel
commented
Jun 19, 2017
sjaeckel
commented
- Use the same header/footer for all files
- Fix some open issues
Member
|
There are still some old URLs |
Member
|
We should perhaps also remove Tom's email from: |
karel-m
reviewed
Jun 19, 2017
| DESTDIR = /usr/local | ||
| DESTDIR = | ||
| PREFIX = /usr/local | ||
| LIBPATH = $(DESTDIR)$(PREFIX)/lib |
Member
There was a problem hiding this comment.
You probably wanted to use LIBPATH & co. later in the makefile.unix or not?
Member
Author
There was a problem hiding this comment.
Ah, I forgot to remove that again... or do you think we should use LIBPATH & co. in all makefiles?
Member
There was a problem hiding this comment.
I am fine with having just PREFIX in makefile.unix
karel-m
reviewed
Jun 19, 2017
|
|
||
| #The following can be overridden from command line e.g. "make -f makefile.unix CC=gcc ARFLAGS=rcs" | ||
| DESTDIR = /usr/local | ||
| DESTDIR = |
Member
There was a problem hiding this comment.
The DESTDIR = should be perhaps completely removed
Member
Author
There was a problem hiding this comment.
Ah damn, yeah... or we use it so #232 would also be solved for makefile.unix
karel-m
reviewed
Jun 20, 2017
| MARKER | ||
| my @all_files; | ||
| find({ wanted=> sub { push @all_files, $_ if $_ =~ /\.(c|h)$/ }, no_chdir=>1 }, 'src'); | ||
| find({ wanted=> sub { push @all_files, $_ if $_ =~ /\.(c|h)$/ }, no_chdir=>1 }, 'demos'); |
Member
There was a problem hiding this comment.
better:
find({ wanted=> sub { push @all_files, $_ if $_ =~ /\.(c|h)$/ }, no_chdir=>1 }, 'src', 'demos', 'tests');
Member
|
👍 I am for merging (just small cosmetics in helper.pl - see my comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.