Fix ccm_memory() cleaning user-supplied key#327
Merged
Conversation
karel-m
reviewed
Nov 20, 2017
| mask = 0; | ||
| zeromem(skey, sizeof(*skey)); | ||
| if (skey != uskey) { | ||
| zeromem(skey, sizeof(*skey)); |
Member
There was a problem hiding this comment.
There is already if (skey != uskey) couple of lines above (line 334).
Should not it be better to move zeromem(skey, sizeof(*skey)) there?
Member
Author
There was a problem hiding this comment.
so you mean like this?
cipher_descriptor[cipher].done(skey);
#ifdef LTC_CLEAN_STACK
zeromem(skey, sizeof(*skey));
#endif
would be fine for me
we shouldn't clean user-supplied variables
sjaeckel
force-pushed
the
fix/ccm_segfault
branch
from
e094103 to
2a5f5cf
Compare
sjaeckel
added a commit
that referenced
this pull request
Dec 5, 2017
Fix ccm_memory() cleaning user-supplied key (cherry picked from commit 85ac227)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a segfault caused by
ccm_memory()withLTC_CLEAN_STACKenabled.