Skip to content

Conversation

@karel-m
Copy link
Member

@karel-m karel-m commented May 23, 2018

Add doc for changes introduced in 24c0eb8

  • new ecc_get_curve(const char* name_or_oid, const ltc_ecc_curve** cu)
  • new ecc_set_dp(const ltc_ecc_curve *cu, ecc_key *key)
  • new ecc_generate_key(prng_state *prng, int wprng, ecc_key *key)
  • new ecc_set_key(const unsigned char *in, unsigned long inlen, int type, ecc_key *key)
  • new ecc_get_key(unsigned char *out, unsigned long *outlen, int type, const ecc_key *key)
  • new ecc_get_oid_str(char *out, unsigned long *outlen, const ecc_key *key)
  • obsolete: ltc_ecc_set_type (replaced by ltc_ecc_curve)

From the last part of ECC changes:

  • new ecc_export_openssl
  • new ecc_import_openssl
  • new ecc_import_x509

It will take some time.

@karel-m karel-m self-assigned this May 23, 2018
@sjaeckel
Copy link
Member

I allowed myself to kill your travis build as it only changes docs that aren't built anyways :)

Btw. I think [skip ci] is useful in cases like that

@karel-m karel-m added this to the next milestone Jun 7, 2018
@karel-m karel-m force-pushed the pr/ecc-doc-update branch from 5048be4 to 6ba84a4 Compare June 11, 2018 18:10
@karel-m karel-m force-pushed the pr/ecc-doc-update branch 4 times, most recently from 7550d2c to 7463fb4 Compare June 21, 2018 15:42
@karel-m karel-m requested a review from sjaeckel June 21, 2018 15:44
@karel-m karel-m force-pushed the pr/ecc-doc-update branch from 7463fb4 to f1cc2a2 Compare June 22, 2018 10:32
@karel-m
Copy link
Member Author

karel-m commented Jun 30, 2018

@sjaeckel ping

It would be nice to have the doc updated as there are questions related to the new ecc API e.g. #419

@karel-m karel-m force-pushed the pr/ecc-doc-update branch from f1cc2a2 to 02e54cb Compare July 2, 2018 22:14
@sjaeckel
Copy link
Member

sjaeckel commented Jul 3, 2018

I think I'm done with it.

Feel free to have another look over it and/or merge please :)

@sjaeckel
Copy link
Member

sjaeckel commented Jul 3, 2018

Ah, I forgot that I've added some comments/questions, can you please comment on them before merging?

@karel-m
Copy link
Member Author

karel-m commented Jul 3, 2018

Ad ecc_set_curve instead of ecc_set_dp - I am for renaming. I'll update the doc to use ecc_set_curve and create a separate PR with the actual renaming.

Ad ecc_make_key_ex I'll move it to Legacy Key Generation

@karel-m
Copy link
Member Author

karel-m commented Jul 4, 2018

@sjaeckel please have a look at the last two commits

Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

please merge after #423

@karel-m karel-m force-pushed the pr/ecc-doc-update branch from d8f30b1 to 4f3bce1 Compare July 6, 2018 11:43
@karel-m karel-m merged commit e02694c into develop Jul 6, 2018
@karel-m karel-m deleted the pr/ecc-doc-update branch July 6, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On documentation: Add list of all supported ciphers, modes, hash algorithms, curves and so on

3 participants