rename ecc_set_dp >> ecc_set_curve + ecc_get_curve >> ecc_find_curve #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
find is indeed better 👍 |
karel-m
force-pushed
the
pr/ecc_set_dp--ecc_set_curve
branch
from
ee1d3ec to
5feac4b
Compare
karel-m
force-pushed
the
pr/ecc_set_dp--ecc_set_curve
branch
from
5feac4b to
4bec98f
Compare
karel-m
changed the title
sjaeckel
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #393
Now we have similarly named:
int ecc_get_curve(const char* name_or_oid, const ltc_ecc_curve** cu);int ecc_set_curve(const ltc_ecc_curve *cu, ecc_key *key);I am not sure whether
ecc_get_curveis proper here, maybeecc_find_curvewould be better?