Skip to content

fix clang-tidy warning: inconsistent-declaration-parameter-name #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2018
Merged

fix clang-tidy warning: inconsistent-declaration-parameter-name #417

merged 1 commit into from
Jul 3, 2018

Conversation

@karel-m
Copy link
Member

@karel-m karel-m commented Jun 22, 2018

see #376

@karel-m karel-m requested a review from sjaeckel June 22, 2018 23:44
@karel-m karel-m mentioned this pull request Jun 25, 2018
Closed
1 task
@karel-m karel-m force-pushed the pr/clang-tidy-readability-inconsistent-declaration-parameter-name branch from 0af6505 to 1445ca9 Compare July 3, 2018 08:15
sjaeckel
sjaeckel approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karel-m karel-m force-pushed the pr/clang-tidy-readability-inconsistent-declaration-parameter-name branch from 1445ca9 to 12c3091 Compare July 3, 2018 20:34
@karel-m karel-m merged commit 48ad48f into develop Jul 3, 2018
@karel-m karel-m deleted the pr/clang-tidy-readability-inconsistent-declaration-parameter-name branch July 3, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjaeckel sjaeckel sjaeckel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karel-m @sjaeckel