avoid ctype toupper #179
Merged
avoid ctype toupper #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minad
commented
Mar 23, 2019
minad
commented
- libc toupper is locale dependent
- removes the dependency on ctype.h
Member
Author
|
@sjaeckel Are there objections to #176, #177, #178, #179? I split them to make merging and checking easy. Maybe it seems that there is more to it than there is? Do you need some words about the motivation? While these are very minor nitpicks, these are issues I have to fix by patching tommath in a downstream project. I am working on a unikernel project, where there is essentially no libc (no stdio, no ctype etc). tommath compiles well there except for those issues :) |
- libc toupper is locale dependent - removes the dependency on ctype.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.