Replace all instances of \d with [0-9] in regular expressions#27
Merged
Conversation
This hardens the date parsing to ensure that only ASCII dates are parsed. Otherwise Unicode digits will be accepted, but improperly parsed as 0.
oalders
force-pushed
the
rrwo/ASCII-dates-only
branch
from
June 25, 2026 14:10
9a4f4bc to
d1bc7a0
Compare
Verifies that dates written with non-ASCII Unicode digits (e.g. Arabic-Indic U+0660..U+0669) are rejected rather than coerced to 0. Guards the \d -> [0-9] hardening in str2time/parse_date. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oalders
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hardens the date parsing to ensure that only ASCII dates are parsed. Otherwise Unicode digits will be accepted, but improperly parsed as 0.