fix(gui): use official brand marks for commandcode and openai icons - #1074
Conversation
- add a dedicated commandcode-color.svg (Command Code ⌘ mark in brand purple #8C4EDD) and register the commandcode provider alias plus its "Command Code" display name, replacing the fallback initial tile - correct openai.svg from the wrong purple #412991 to the official OpenAI green #10A37F Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
This pull request mentions @Wibias Please add a screenshot of the UI change to the description — drag and drop the image into the description editor, or paste a markdown image such as Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required |
|
✅ Deterministic PR hygiene checks passed. |
📝 WalkthroughWalkthroughThe change adds Command Code to the provider icon alias map with its colored SVG asset and display name. Tests verify the icon path and the ChangesCommand Code icon support
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@gui/src/provider-icons.ts`:
- Line 67: Update formatProviderDisplayName and its provider-name configuration
so commandcode is included in PROVIDER_DISPLAY_NAME_KEYS and resolved through
the existing locale lookup path instead of the hardcoded PROVIDER_DISPLAY_NAMES
fallback. Add the matching commandcode translation to each locale resource, and
update the related test to assert the localized key path rather than only
englishT.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: db477768-beb7-4791-a61a-93147106c103
⛔ Files ignored due to path filters (2)
gui/public/provider-icons/commandcode-color.svgis excluded by!**/*.svggui/public/provider-icons/openai.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
gui/src/provider-icons.tstests/provider-workspace-data.test.ts
| "cloudflare-workers-ai": "Cloudflare Workers AI", | ||
| cline: "Cline", | ||
| "cline-pass": "ClinePass", | ||
| commandcode: "Command Code", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Route Command Code through the locale files.
formatProviderDisplayName returns PROVIDER_DISPLAY_NAMES[key] directly when no localized key exists. This hardcoded value prevents locale-specific translations for commandcode.
Add commandcode to PROVIDER_DISPLAY_NAME_KEYS and define the matching value in the locale resources. Update the test to verify the localized key path, not only englishT.
As per path instructions, user-visible strings must go through i18n locale files rather than hardcoded text.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@gui/src/provider-icons.ts` at line 67, Update formatProviderDisplayName and
its provider-name configuration so commandcode is included in
PROVIDER_DISPLAY_NAME_KEYS and resolved through the existing locale lookup path
instead of the hardcoded PROVIDER_DISPLAY_NAMES fallback. Add the matching
commandcode translation to each locale resource, and update the related test to
assert the localized key path rather than only englishT.
Source: Path instructions
Summary
commandcodewas rendering with the fallback initial-letter tile because it had no icon alias. Added a dedicatedcommandcode-color.svgasset using the official Command Code brand mark (the ⌘ glyph in a rounded frame, brand purple#8C4EDD, sourced from the publishedcommandcode.ailogo) and registered thecommandcode→commandcode-color.svgalias plus the "Command Code" display name ing ui/src/provider-icons.ts.g ui/public/provider-icons/openai.svgused the wrong purple#412991; corrected to the official OpenAI brand green#10A37F.Verification
bun scripts/test.ts provider-workspace-data.test.ts— 46 pass / 0 fail, including a new assertion thatproviderIconSrc("commandcode")resolves to/provider-icons/commandcode-color.svgand its display name is "Command Code".bun x tsc --noEmit— clean.Checklist
Summary by CodeRabbit
New Features
Tests