chore(proxy): update MCP SDK and protobuf, clear hono advisories - #1250
Merged
Conversation
Bump @modelcontextprotocol/sdk 1.29.0 -> 1.30.0: - widen @hono/node-server past GHSA-frvp-7c67-39w9 (path traversal) - stricter Content-Type validation, SSE keep-alive + timer lifecycle fixes - Zod 3.25 method literal support, stdio buffer limit Bump @bufbuild/protobuf 2.12.1 -> 2.13.0: - Protobuf Text Format support, erasable enum syntax, readMaxBytes option Pin hono overrides to clear remaining audit findings: - @hono/node-server 2.1.0 (GHSA-frvp-7c67-39w9) - hono 4.13.1 (GHSA-8j4g-w8fx-2239, GHSA-f23p-vx2j-j53r, GHSA-79qm-7rj5-m7r9, GHSA-54fx-42gc-7vw4)
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hono/node-serverdependency-range widening past GHSA-frvp-7c67-39w9, stricter Content-Type validation, SSE keep-alive + timer-lifecycle fixes, Zod 3.25 method-literal support, and a stdio buffer limit.readMaxBytesoption forsizeDelimitedDecode.bun auditfindings in the MCP SDK dependency tree:@hono/node-server2.1.0 (GHSA-frvp-7c67-39w9) andhono4.13.1 (GHSA-8j4g-w8fx-2239, GHSA-f23p-vx2j-j53r, GHSA-79qm-7rj5-m7r9, GHSA-54fx-42gc-7vw4).package.json+bun.lockonly.Validation
bun run typecheck— passbun audit— pass, 0 vulnerabilities after overridesbun install --frozen-lockfile --dry-run— pass, lockfile consistentbun run testcannot complete on this Windows host: Bun 1.3.14 crashes mid-suite (documented inci.yml— the repo avoids hosted-Windows full-suite runs for this reason) and 7codex-native-residuetests fail from a Windows account-lookup environment issue. Both reproduce identically on the cleandevbase (56 pass / 2 skip / 7 fail in that file on base and head alike). CI runs the suite on Linux shards and is the authoritative test gate.Review notes
@hono/node-serverto^1.19.9 || ^2.0.5, but bun resolves the 1.x line to 1.19.14 which is still below the advisory fix<2.0.5; the override forces 2.1.0 (same forhono, where^4.11.4resolves below the fixed 4.12.34).Summary by CodeRabbit