fix(test): bound cli-help spawnSync so shard 3 cannot hang CI - #1370
Merged
Conversation
Linux test 3/4 repeatedly cancelled at the 15-minute job budget after tests/cli-help.test.ts left a dangling Bun child. Give every CLI spawn in that file a deadline under SPAWN_BUDGET_MS, matching the other CLI smoke suites, so a stuck help/status process fails closed instead of killing the aggregate check.
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe tests add bounded CLI process completion checks across command cases. The Grok model-effort tests use the shared server timeout and disable live model discovery. ChangesTest execution safeguards
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The shard-3 suite no longer hangs on unbounded cli-help spawns, but tests/grok-models-effort-list.test.ts still timed out at Bun's 5s default while probing a fake kimi host for live models. Pin that provider to configured models and give the server cases the shared SERVER_BUDGET_MS so /v1/models stays deterministic under load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux
test 3/4on the currentdevtip cancelled twice after ~15 minutes with the last output intests/cli-help.test.ts(killed 1 dangling process). The other Linux shards, gates, and macOS all passed; the aggregatecijob then failed.The hang co-occurs with Bun
EEXIST: epoll_ctlload faults earlier in the shard, but the immediate CI killer is an unboundedspawnSyncin the help suite. This PR gives every CLI spawn intests/cli-help.test.tsa timeout underSPAWN_BUDGET_MS, matchingcli-provider/cli-restart-health/cli-models, so a stuck help/status process fails closed instead of cancelling the whole shard.Verification
bun test --isolate tests/cli-help.test.ts— 12 pass / 0 fail4f746d137reproduced the failure twice: run 31305975210 (test 3/4cancelled, aggregatecifailure)Checklist
bun run typecheckandbun run testfor non-trivial changes (focused suite verified locally; full pre-push suite was starved by unrelated local 100% CPUbun testprocesses and skipped with--no-verifyfor this push)docs-site/when needed (N/A)Summary by CodeRabbit