Skip to content

fix(codex): keep unreadable shim checks advisory - #1372

Merged
Wibias merged 1 commit into
lidge-jun:devfrom
luvs01:agent/fix-codex-shim-readiness
Aug 10, 2026
Merged

fix(codex): keep unreadable shim checks advisory#1372
Wibias merged 1 commit into
lidge-jun:devfrom
luvs01:agent/fix-codex-shim-readiness

Conversation

@luvs01

@luvs01 luvs01 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep the post-install Codex shim readiness check advisory when the Codex config cannot be read or changes between existence and read checks.
  • Reuse the existing getCodexRoutingKind() fallback so the install succeeds and emits the generic routing-verification warning instead of failing after the shim has already been written.
  • Add a cross-platform end-to-end regression with config.toml represented by an unreadable directory and platform-appropriate Codex launchers.

Verification

  • bun test tests/codex-shim-readiness.test.ts — 6 passed, 0 failed.
  • bun run typecheck
  • bun run privacy:scan
  • git diff --check
  • Independent focused diff review: no P0-P3 findings.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (No documentation change is needed for this failure-path fix.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wibias, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 221d5317-750b-46d0-a780-2476f1d36c89

📥 Commits

Reviewing files that changed from the base of the PR and between d517161 and 1eb8ce3.

📒 Files selected for processing (2)
  • src/cli/codex-shim-readiness.ts
  • tests/codex-shim-readiness.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

✅ READY

  • all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

  • ✅ All CI tests are green on my local testing.
  • ✅ I pushed my PR to the latest dev commit.
  • ✅ I resolved all correct Codex and CodeRabbit findings.
  • ✅ My PR is ready for review.

4/4 boxes ticked.

This pull request is already Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently. If no CodeRabbit review appears, comment @coderabbitai review to request one.
Maintainers: @lidge-jun @Ingwannu @Wibias

Wibias commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Please rebase this PR onto the latest dev (e8ce2b93dd3ef8074d96dee407704c5dc06e2699) before merge, then rerun the exact-head CI checks.

@luvs01
luvs01 force-pushed the agent/fix-codex-shim-readiness branch from 132e4bf to 1eb8ce3 Compare August 9, 2026 23:25
@Wibias
Wibias marked this pull request as ready for review August 9, 2026 23:45
@Wibias
Wibias merged commit 2462868 into lidge-jun:dev Aug 10, 2026
43 of 49 checks passed

Wibias commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks @luvs01 — good failure-path hardening. Keeping the post-install readiness check advisory avoids turning an unreadable/racy Codex config into a false install failure, while preserving the existing warning behavior. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working review-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants