ci(service-lifecycle): trigger on release.yml; devlog for the bot-PR toggle - #3269
Conversation
…-lifecycle trigger gap
…gate cannot dead-end release.yml requires a service-lifecycle run for the release SHA when any gated path changed since the previous tag, but a release-branch commit that touched only release.yml (the v2.40.0 permissions carry, #3263/#3264) matched no lifecycle trigger path, so both dispatches needed a manual run. The path is now in both trigger lists and the gate regex; tests/ci-workflows keeps the three in sync.
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Owner admin merge, user-authorized (release-train follow-ups). Workflow trigger widening + devlog; ci-workflows 135 pass locally. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Service lifecycle workflow now runs when ChangesRelease lifecycle gating
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
service-lifecycle.ymlnow also triggers on.github/workflows/release.yml(push and pull_request), andrelease.yml's service gate regex lists the same path. A release-branch commit that touched onlyrelease.yml([WRONG BRANCH] release: carry the release.yml permissions fix onto main for v2.40.0 #3263/[WRONG BRANCH] release: carry the release.yml permissions fix onto preview for v2.40.0-preview.20260902 #3264 for v2.40.0) produced no lifecycle run, so the gate dead-ended and both dispatches needed a manualworkflow_dispatch.devlog/_plan/260902_windows_ci_release/080_release_automation_followups.md: provenance of the repository toggle "Allow GitHub Actions to create and approve pull requests" (never on — GitHub default, three datedfalsereadings, no disabling commit/devlog/chat), the least-privilege decision, and the applied change via REST (read-backtrue). That toggle is a repository setting, not a file in this PR.Verification
bun test tests/ci-workflows.test.ts135 pass — it pins that the PR and push path lists match and that every push path satisfies the release gate regex.bun run privacy:scangreen.Checklist
Summary by CodeRabbit