Skip to content

ci(service-lifecycle): trigger on release.yml; devlog for the bot-PR toggle - #3269

Merged
lidge-jun merged 4 commits into
devfrom
codex/release-automation-followups
Sep 2, 2026
Merged

ci(service-lifecycle): trigger on release.yml; devlog for the bot-PR toggle#3269
lidge-jun merged 4 commits into
devfrom
codex/release-automation-followups

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • bun test tests/ci-workflows.test.ts 135 pass — it pins that the PR and push path lists match and that every push path satisfies the release gate regex.
  • bun run privacy:scan green.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (GitHub Actions: widens a trigger only; no permission or secret change. The repo toggle's security note is in 080.)

Summary by CodeRabbit

  • Bug Fixes
    • Release workflow changes now trigger the required service validation before publishing.
    • Service lifecycle checks now run when release workflow configuration changes, including release-branch updates.
  • Documentation
    • Added planning documentation covering release automation follow-ups and repository workflow configuration.

jun added 4 commits September 2, 2026 19:51
…gate cannot dead-end

release.yml requires a service-lifecycle run for the release SHA when any
gated path changed since the previous tag, but a release-branch commit that
touched only release.yml (the v2.40.0 permissions carry, #3263/#3264) matched
no lifecycle trigger path, so both dispatches needed a manual run. The path
is now in both trigger lists and the gate regex; tests/ci-workflows keeps the
three in sync.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 2, 2026 10:52
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T10:57:17.832454Z b84eafc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 2, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Owner admin merge, user-authorized (release-train follow-ups). Workflow trigger widening + devlog; ci-workflows 135 pass locally.

@lidge-jun
lidge-jun merged commit ee24bab into dev Sep 2, 2026
25 of 27 checks passed
@lidge-jun
lidge-jun deleted the codex/release-automation-followups branch September 2, 2026 10:53
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 05cce0e4-275a-4967-9d20-cf5b6b5fb244

📥 Commits

Reviewing files that changed from the base of the PR and between 7424719 and b84eafc.

📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • .github/workflows/service-lifecycle.yml
  • devlog/_plan/260902_windows_ci_release/080_release_automation_followups.md

📝 Walkthrough

Walkthrough

The Service lifecycle workflow now runs when .github/workflows/release.yml changes. The release gate also requires that lifecycle run. A planning document records the related repository permission decision and workflow path-filter issue.

Changes

Release lifecycle gating

Layer / File(s) Summary
Align workflow triggers and release gate
.github/workflows/service-lifecycle.yml, .github/workflows/release.yml
The pull_request and push path filters include .github/workflows/release.yml at lines 17–20 and 31–34. The release gate includes the same path in its grep -Eq pattern at line 268.
Record release automation follow-ups
devlog/_plan/260902_windows_ci_release/080_release_automation_followups.md
The document records the repository workflow-permission history and decision at lines 1–42. It also records the Service lifecycle path-filter gap and the matching trigger and gate updates at lines 44–51.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/release-automation-followups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant