test(layout): move server, storage, ci-workflows into tests/<domain>/ (#3497) - #3518
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (172)
📝 WalkthroughWalkthroughThis change moves CI workflow, server, and storage tests into domain directories. It updates imports, fixtures, workflow commands, scripts, documentation, comments, and repository-root path resolution. It also adds documentation-claim coverage for 429 failover behavior. ChangesTest layout migration
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
chore
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
⏳ DRAFT
What to do
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required |
리뷰 · 우선순위 62 / 80이 PR은 이슈 #3497(테스트 파일을 옮기는 묶음은 이번 슬라이스가 특히 중요한 이유는 CI·릴리스 경로 문자열이 여기 몰려 있기 때문입니다. 도구 쪽도 두 군데 손봤습니다. (1) 검증 메모: 세 도메인 참고로
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
2426be1 to
d97ea08
Compare
77190ee to
8ee99eb
Compare
8ee99eb to
03433b1
Compare
d901723 to
798e003
Compare
7a1dad7 to
5808a7f
Compare
… of anthropic-quorum-cache
…moved the duplicate
5808a7f to
33ffae2
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5808a7f672
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `scripts/test-layout/move.ts` and `layout.migrated` records which domains | ||
| have moved, so until a domain is listed there its files are still at the | ||
| root. `tests/test-layout.test.ts` enforces the map. Shared helpers in | ||
| root. `tests/ci-workflows/test-layout.test.ts` enforces the map. Shared helpers in |
There was a problem hiding this comment.
The layout guard remains tests/test-layout.test.ts and is explicitly listed in scripts/test-layout/layout.json under keepAtRoot; no tests/ci-workflows/test-layout.test.ts exists. When a contributor follows this path, Bun reports an unmatched filter but exits successfully, so the intended layout enforcement can be silently skipped. Keep this reference as tests/test-layout.test.ts.
Useful? React with 👍 / 👎.
1 participant
Summary
Last move slice of #3497, stacked on #3516:
server(96),storage(18) andci-workflows(28) move intotests/<domain>/withgit mv. After this PR the only*.test.tsfiles at thetests/root are the two layout guards; every other test lives under its domain (plan.ts: 0 moves left).This slice carries the path edits the plan reserved for last: the storage-policy job list in
ci.yml,scripts/release.tsISOLATED_TEST_FILES, theapi-usagejob line,dev-version-bump.yml'srelease-version-lineinvocations, the.github/scripts/pr-quality.test.cjsfixtures, and theci-workflows.test.ts/zz-ci-*oracles that pin them.scripts/test.tsgetscodex-integration/issue-452-empty-503.test.tsandci-workflows/release-helper.test.tsas serial-lane entries (the timeout table stays keyed by basename; the mover now only rewrites inside the array)..gitignoregainstests/**/.tmp-*so per-test scratch dirs stay ignored inside domain folders. Four MANUAL lines (new URL(entry.path, ...)over an array,test-runner's self-spawn) were hand-edited;keepAtRootnow beats the regex seeds inresolveTargetso the guards cannot be swept intoci-workflows/by theirtest-prefix.Verification
move.tsthenverify.tsfor the three domains: 0 stale literals, 0 unsuppressed escapes, 0 module-resolution errors;bun test --isolate --parallel=4over the three directories: 2393 pass, 0 fail (142 files).bun test tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/{test-runner,ci-workflows,zz-ci-storage-policy-isolation,zz-ci-api-usage-isolation,repo-hygiene}.test.ts: 209 pass.node --test .github/scripts/pr-quality.test.cjsgreen.bun x tsc --noEmit,bun run privacy:scan: green.ci: the storage-policy and api-usage isolated jobs are the direct proof for the three-way edit.Checklist
Summary by CodeRabbit
Tests
Documentation
Chores