fix(release): full channel changelog in GitHub release notes#364
Merged
Conversation
generate-notes is PR-only, so preview/latest changelogs missed branch merges and direct commits; append the full channel git log for both create and edit paths.
This comment was marked as resolved.
This comment was marked as resolved.
Address CodeRabbit: require generate-notes success, always create (preflight already blocks existing releases), keep a 100-commit cap only for first-channel history, and tighten workflow contract tests.
Avoid leaving a remote tag when generate-notes fails; preflight would otherwise block retries after a partial publish.
Collaborator
Author
Dual review (security + bugs/edge cases)CodeRabbit threads addressed on CodeRabbit disposition
Extra fix from this review: assemble notes before SecurityVerdict: merge-ready for security (no blockers). Checked:
Bugs / edge casesVerdict: merge-ready after the notes-before-tag reorder. Remaining residuals are operational, not blockers:
Checks
|
Omitting previous_tag_name lets GitHub baseline the newest repo tag, which can be the other channel on a first preview/stable cut. Use commits-only notes in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-notesPR categories and append a## Commitssection from the channel-scoped previous tag (branch merges + direct commits that PR-only notes omit).--notes-filebody so republishing a tag gets the same full notes.--generate-notesis no longer used alone on create.Test plan
bun test tests/ci-workflows.test.tsworkflow_dispatchpublish: verify release body has PR categories, Commits list, and Full Changelog compare linkSummary by CodeRabbit
Improvements
Tests