fix(kiro): keep progress text nonterminal#369
Merged
lidge-jun merged 1 commit intoJul 24, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughKiro required-mode turns containing text or reasoning now use one bounded completion fallback. Unit and end-to-end tests verify retry state and progress/final-answer streaming across Responses and Messages endpoints, and transport documentation reflects the updated behavior. ChangesKiro completion fallback
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant KiroStream
participant KiroAdapter
participant CompletionFallback
participant APIEndpoints
KiroStream->>KiroAdapter: progress text or reasoning
KiroAdapter->>CompletionFallback: request bounded completion
CompletionFallback-->>KiroAdapter: final answer
KiroAdapter-->>APIEndpoints: commentary and final_answer output
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
lidge-jun
added a commit
that referenced
this pull request
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assistantResponseEventcontaining progress text followed by a clean Smithy EOF was emitted as commentary but also completed withend_turn: true. A response such as "I am checking" could therefore terminate Codex or Claude Code before the model produced a final answer./v1/responsesplus/v1/messagesregressions proving progress is preserved structurally, the continuation runs exactly once, and the private completion tool never leaks.Verification
bun test --isolate tests/kiro-stream.test.ts tests/server-kiro-completion-e2e.test.ts(58 pass)bun run typecheckbun run test(3933 pass across 314 files)bun run privacy:scangit diff --checkChecklist
Summary by CodeRabbit
Bug Fixes
Tests