feat(models): delete custom definitions and hide provider rows - #3721
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (57)
📝 WalkthroughWalkthroughThe change adds static default-model seeding and updates catalog documentation and tests. It also adds validated model inventory handling and provider-workspace controls for adding, deleting, hiding, restoring, and counting models. ChangesCatalog and provider model management
Estimated code review effort: 5 (Critical) | ~120 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ProviderWorkspaceShell
participant ModelInventory
participant ProviderModelInventory
participant CustomModelAPI
participant ModelVisibilityAPI
ProviderWorkspaceShell->>ModelInventory: Parse paired model snapshots
ModelInventory-->>ProviderWorkspaceShell: Return rows, selection, revision, and counts
ProviderWorkspaceShell->>ProviderModelInventory: Pass current rows and readiness
ProviderModelInventory->>CustomModelAPI: Read custom ownership
ProviderModelInventory->>CustomModelAPI: Delete custom definition when confirmed
ProviderModelInventory->>ModelVisibilityAPI: Update visibility when Hide is confirmed
ProviderModelInventory->>ProviderWorkspaceShell: Request refresh and reconcile persisted state
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 59 / 80이 PR은 핵심 파일은 주의할 점이다. 파일 목록에 우선순위 59인 이유다. 경로/심볼 - 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Add real gather controls for omitted/empty models, retained-id deduplication, explicit-list precedence, OAuth/forward no-request paths, and authoritative empty live discovery. Align eight-language static documentation and the source of truth. Co-authored-by: gqchen <276851182@qq.com>
The legacy Go fixture already receives a registry default under existing ownership rules. Require exactly that singleton under static seeding, with no metadata roster or network calls. Keep genuine no-default emptiness and add strict custom MiMo transport negatives. Production seeding and ownership rules remain unchanged. Co-authored-by: gqchen <276851182@qq.com>
Use existing model DTOs and revision-bound ownership for one-operation custom deletion and row hiding. Preserve native restoration, independent visibility, namespace collisions and ordinary copy/default behavior. Reconcile uncertain writes without duplicate mutations or tombstones; expose existing Models recovery. Add real API and asynchronous UI regression coverage plus all locales and dashboard docs. Co-authored-by: gqchen <276851182@qq.com>
9af03d0 to
285832f
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Summary
Provider Models now distinguishes deleting a custom definition from hiding a catalog row. Delete uses the stored record ID and can reveal an underlying native or discovered model; Hide changes only the represented row's visibility. The existing Models page remains available to restore hidden rows, including from an empty provider tab.
The workspace uses existing canonical model DTOs for identity, counts and actions. It waits for current model/selection observations and custom ownership before writing, preserves account-native/manual namespace collisions, and reconciles failed or ambiguous replies without duplicate writes, implicit unhide or browser-only removal markers. Counts describe non-disabled inventory before search/truncation, not selected-model or upstream-discovery counts.
This is the UI child of #3717 and carries the remaining #3659 work from ff4e5cd, preserving gqchen's contribution. Original #3659 closes only after both capabilities are verified on dev. The source diff uses its true merge base; previously integrated Grok text/settings were preserved after correcting our carry boundary.
Landing: rebased onto dev 2f124a1 at the maintainer's explicit request, with original gqchen commit authors preserved. Rebased head 285832f has tree dbb5c1909c5a11467ce3d7346b990125a4a35b07, identical to the previously inspected clean composition of dev and the tested pre-rebase head. Admin merge is explicitly authorized without waiting for post-rebase CI. The static parent #3717 is included by equivalent rebased commits, not by its old commit IDs. Original #3659 and the superseded parent will close after inclusion on dev is verified.
Verification
Actual remotely compiled dashboard with synthetic API state: discovered Hide, custom Delete, matching inventory count and Models recovery. Capture source a02ab77; this artifact commit preserves those application bytes. Persistence, error recovery and the true 390px viewport were subsequently verified on the same application bytes.
Checklist
Co-authored-by: gqchen 276851182@qq.com
Summary by CodeRabbit
New Features
Documentation