Skip to content

Fix apply_patch envelope guidance#377

Merged
lidge-jun merged 1 commit into
lidge-jun:devfrom
HaydernCenterpoint:fix/apply-patch-freeform
Jul 24, 2026
Merged

Fix apply_patch envelope guidance#377
lidge-jun merged 1 commit into
lidge-jun:devfrom
HaydernCenterpoint:fix/apply-patch-freeform

Conversation

@HaydernCenterpoint

@HaydernCenterpoint HaydernCenterpoint commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #372.\n\nClarifies the freeform �pply_patch input contract so routed models emit the exact required *** Begin Patch header rather than the invalid *** Begin Patch *** variant.\n\nValidation: �un test tests/responses-parser.test.ts, �un run typecheck.

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of freeform patch tool inputs by clarifying the required patch format.
  • Tests

    • Added coverage to verify that patch-based tool definitions retain the correct name, freeform behavior, and input guidance.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 03:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 86428a76-31af-42f9-a009-f7e945b14fc8

📥 Commits

Reviewing files that changed from the base of the PR and between c1b0b1c and 9296f2d.

📒 Files selected for processing (2)
  • src/responses/parser.ts
  • tests/responses-parser.test.ts

📝 Walkthrough

Walkthrough

The custom tool input description now specifies the required apply_patch envelope prefix, and a parser test verifies the tool name, freeform flag, and input schema description.

Changes

Apply Patch envelope

Layer / File(s) Summary
Update apply_patch schema guidance and validation
src/responses/parser.ts, tests/responses-parser.test.ts
The custom tool input description now requires *** Begin Patch without a trailing ***, while the new test verifies the parsed apply_patch tool metadata and description.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: copilot, ingwannu, lidge-jun

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: clarifying apply_patch envelope guidance.
Linked Issues check ✅ Passed The parser description and new test directly address #372 by requiring the apply_patch input to begin with *** Begin Patch.
Out of Scope Changes check ✅ Passed The changes stay narrowly scoped to parser guidance and a validating test, with no unrelated behavior changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Wibias

Wibias commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes #372.\n\nClarifies the freeform �pply_patch input contract so routed models emit the exact required *** Begin Patch header rather than the invalid *** Begin Patch *** variant.\n\nValidation: �un test tests/responses-parser.test.ts, �un run typecheck.

Uhm, what. Can u please redo that pr description

@lidge-jun
lidge-jun merged commit 6b66ef1 into lidge-jun:dev Jul 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants