Skip to content

docs(credits): restore missing stacked-PR contributor attribution - #3787

Merged
lidge-jun merged 1 commit into
devfrom
codex/restore-stack-contributor-credit-3000
Sep 6, 2026
Merged

docs(credits): restore missing stacked-PR contributor attribution#3787
lidge-jun merged 1 commit into
devfrom
codex/restore-stack-contributor-credit-3000

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Restore contributor attribution for 44 additional source pull requests found by auditing the last 3,000 commits on dev. Each entry identifies the source author, the landed commit and the maintainer's explicit carry statement.
  • Distinguish missing/malformed trailers from three landings whose trailers do not resolve to the original GitHub account. Keep two ambiguous landed-only acknowledgements separate from carried work.
  • Add account-linked Co-authored-by trailers for 33 contributors, including the earlier carried-work entries already documented in CREDITS.md. This is a forward correction; published commit objects and tags are not rewritten.

Verification

  • Audited exactly 3,000 commits from dev 7d8523e through 53130de, resolving source PRs, closure evidence and actual GitHub commit-author mappings.
  • Verified every new landing is in dev ancestry, source-account numeric IDs match the trailers, 33 trailers are unique, the patch changes only CREDITS.md, and git diff --check passes.
  • No tests, typecheck, build or CI dispatch were run. The owner explicitly requested a documentation-only quick merge without running or waiting for CI; [skip ci] is present on the correction commit.
  • Owner-authorized maintainer integration into dev, without another maintainer approval and with CI explicitly waived for this attribution-only correction. Verified patch head: 0b27bf3. This is not a claim that CI passed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Contributor documentation and machine-readable attribution were updated.
  • No runtime, credential, workflow or release behavior changed; private contributor email addresses are not added to the document.

Summary by CodeRabbit

  • Documentation
    • Added follow-up sections documenting pull requests with missing or unresolvable co-author attribution.
    • Added acknowledgments for source pull requests closed as landed without explicit carry statements.
    • Documented a 3,000-commit audit methodology for verifying landed changes.
    • Expanded citation guidance to include pull-request descriptions.

Record verified carried-work credit omitted or unlinked at the final landing.
Restore forward co-author credit for the carried contributors already documented
in CREDITS.md as well as this follow-up. Preserve all historical commits and tags.

Owner explicitly requested this documentation-only correction be merged into dev
without running or waiting for CI. No tests, typecheck or build were run.

Co-authored-by: agentHits <140916359+agentHits@users.noreply.github.com>
Co-authored-by: benedictusrey <74437942+benedictusrey@users.noreply.github.com>
Co-authored-by: bet4it <16643669+bet4it@users.noreply.github.com>
Co-authored-by: Blushyes <75828899+Blushyes@users.noreply.github.com>
Co-authored-by: chilung-cgu <215337896+chilung-cgu@users.noreply.github.com>
Co-authored-by: darwintree <17946284+darwintree@users.noreply.github.com>
Co-authored-by: dbc-hbin <282618027+dbc-hbin@users.noreply.github.com>
Co-authored-by: drakonkat <17176640+drakonkat@users.noreply.github.com>
Co-authored-by: Eleven-is-cool <54345049+Eleven-is-cool@users.noreply.github.com>
Co-authored-by: Flowershangfromthebranches <152056395+Flowershangfromthebranches@users.noreply.github.com>
Co-authored-by: gaoran1209 <15261543+gaoran1209@users.noreply.github.com>
Co-authored-by: gulup <3413433+gulup@users.noreply.github.com>
Co-authored-by: harryzhou2000 <67385896+harryzhou2000@users.noreply.github.com>
Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
Co-authored-by: jonathanli12 <47408717+jonathanli12@users.noreply.github.com>
Co-authored-by: justin-mc-lai <13780920+justin-mc-lai@users.noreply.github.com>
Co-authored-by: lilinxiong <24367027+lilinxiong@users.noreply.github.com>
Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
Co-authored-by: luvyoun0224-beep <255666866+luvyoun0224-beep@users.noreply.github.com>
Co-authored-by: MarcTCruz <58499846+MarcTCruz@users.noreply.github.com>
Co-authored-by: mdwsk88 <11055210+mdwsk88@users.noreply.github.com>
Co-authored-by: ntdatt812 <188129613+ntdatt812@users.noreply.github.com>
Co-authored-by: olddonkey <22208754+olddonkey@users.noreply.github.com>
Co-authored-by: rrmlima <137737127+rrmlima@users.noreply.github.com>
Co-authored-by: S0RYUASUKA <64878945+S0RYUASUKA@users.noreply.github.com>
Co-authored-by: Skyline-23 <62983047+Skyline-23@users.noreply.github.com>
Co-authored-by: TooSpace <287153855+TooSpace@users.noreply.github.com>
Co-authored-by: turin-dev <201305497+turin-dev@users.noreply.github.com>
Co-authored-by: Veritas-7 <234569343+Veritas-7@users.noreply.github.com>
Co-authored-by: waw4303 <59402644+waw4303@users.noreply.github.com>
Co-authored-by: Yuxin-Qiao <104957188+Yuxin-Qiao@users.noreply.github.com>
Co-authored-by: yxr1995-maker <257504378+yxr1995-maker@users.noreply.github.com>
Co-authored-by: yzxcj797 <54314860+yzxcj797@users.noreply.github.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 6, 2026 16:48
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T16:50:39.892669Z 0b27bf3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 6, 2026
@lidge-jun
lidge-jun merged commit 24c761a into dev Sep 6, 2026
4 of 5 checks passed
@lidge-jun
lidge-jun deleted the codex/restore-stack-contributor-credit-3000 branch September 6, 2026 16:49
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f1e69b2e-d596-44e3-ae1a-fa125b207198

📥 Commits

Reviewing files that changed from the base of the PR and between 7d8523e and 0b27bf3.

📒 Files selected for processing (1)
  • CREDITS.md

📝 Walkthrough

Walkthrough

CREDITS.md records trailer corrections, unresolved contributor links, landing acknowledgements, and a 3,000-commit audit method. It also identifies pull-request descriptions as citation sources and requires verification of the final landing commit.

Changes

Credits audit documentation

Layer / File(s) Summary
Citation and landing verification
CREDITS.md
Lines 26–27 include pull-request descriptions among citation sources. Lines 208–222 document the 3,000-commit audit and require inspection of the final landing commit’s Co-authored-by trailer.
Trailer follow-up records
CREDITS.md
Lines 60–108 list missing or malformed trailers. Lines 109–124 document three unlinked trailers and correction commits. Lines 152–164 acknowledge two landed source pull requests without explicit carried-code statements.

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/restore-stack-contributor-credit-3000

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b27bf377d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CREDITS.md
Comment on lines +121 to +123
The correction commit records these contributors and the earlier **Carried work**
authors as co-authors. This is forward attribution: the old commit objects,
their original dates and release tags are unchanged.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the omitted co-author trailers

The document says this correction commit records the contributors as co-authors, but inspecting dde40573220e2f473570f9cddb3a1e8b42f3197c with Git's trailer parser returns no Co-authored-by values. The referenced patch head 0b27bf377d7cc003d1a478df7cd4d11c198f57d8 had 33 such trailers, but they were lost when the commit message was recreated, so GitHub will not give any of these contributors the forward profile/contributor-graph credit that is the purpose of this change. Restore those trailers on the commit that actually lands.

AGENTS.md reference: AGENTS.md:L279-L283

Useful? React with 👍 / 👎.

@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 54 / 80

이 PR은 런타임·어댑터·릴리스 동작을 바꾸는 패치가 아닙니다. 바꾸는 파일은 CREDITS.md 하나뿐입니다. 지금 dev 는 이미 이 랜딩을 머지한 뒤 HEAD 24c761a05 이고, 직전 HEAD는 7d8523eed (#3783, package.json2.45.0 으로 연 상태)였습니다. 제품 코드 경로(src/adapters/**, 카탈로그, GUI, 워크플로)는 그대로입니다. 목적은 지난 3,000개 dev 커밋 창에서 빠진 stacked-PR 기여자 이름을 앞으로만 고쳐 적는 것입니다. 옛 커밋·태그·클론을 다시 쓰지 않습니다.

왜 지금이냐면, 기여자 크레딧이 랜딩 메시지·스쿼시·잘못된 trailer 때문에 끊기면 GitHub 기여 그래프와 CREDITS.md 에 안 남습니다. 기존 본문은 “닫는 댓글이나 랜딩 커밋의 메인테이너 말만 인용한다”고 했고, 이번 패치는 그 문장을 “PR 설명도 근거로 쓸 수 있다”로 살짝 넓힙니다. 그다음 ## Carried work 아래에 2026-09-07 follow-up 표 두 개(누락/깨진 trailer 41개 + 계정에 안 붙는 trailer 3개)를 넣고, ## Closed as landed, carry not stated#2360·#3621 두 건을 인정만 추가합니다. 끝의 ### Verify the landing, not just the proposal 은 감사 범위(7d8523eed53130de4e)와 “최종 랜딩 커밋의 Co-authored-by가 실제로 계정에 붙는지 보라”는 교훈을 남깁니다.

커밋 0b27bf377 / 머지 24c761a05 에는 계정 연결 noreply 형식 Co-authored-by가 33개 붙어 있습니다. 이미 CREDITS.md 에 있던 carried 기여자와 이번 follow-up 기여자를 같이 앞으로 고칩니다. [skip ci] 와 “문서만 빨리 머지, CI 대기 없음”은 owner가 명시한 그대로입니다. types.ts/config.ts 대분리와 무관하고, 같은 감사 창을 덮는 다른 열린 PR도 없습니다. 글을 쓰는 시점에 이 PR은 이미 dev 에 들어가 있습니다.

한 가지 좋은 예가 #1748 입니다. 소스 PR 작성자는 @Blushyes 인데, 랜딩 커밋 e3bbf5321 본문은 아직 Credit: luvs01 (original PR #1748) 이라고 적혀 있습니다. 이번 표는 이름을 @Blushyes 로 바로잡았고, 옛 커밋 문구는 그대로 둡니다. 그게 이 파일의 설계(히스토리 비재작성)와 맞습니다.

경로 CREDITS.md 서두 - 근거 문장이 “닫는 댓글·랜딩 커밋”에서 “PR 설명”까지 넓어진다. 인용 범위를 키운 만큼, 표 칸이 요약문이 되면 “메인테이너 말만 인용” 원칙과 긴장이 생긴다.
경로 CREDITS.md ### 2026-09-07 follow-up: missing or malformed trailers - 41개 행이 ## Carried work 아래 하위 절로 들어간다. 기존 표와 형식이 조금 다르다(옛 행은 인용문, 새 행은 링크 걸린 요약이 많다).
경로 CREDITS.md #1748 행 - 소스 작성자 @Blushyes 로 고쳤다. 랜딩 e3bbf5321 본문의 luvs01 표기는 히스토리에 남고, 문서만 바로잡는다. 의도된 forward repair다.
경로 CREDITS.md ### unlinked trailers (#2817/#3148/#3293) - trailer 문자열은 있어도 GitHub 계정 매핑이 안 되는 경우를 분리했다. 계정 연결 noreply로 앞으로만 고친다. 개인 메일 주소는 문서에 안 넣었다.
경로 머지 커밋 24c761a05 Co-authored-by 33개 - 문서 표의 carried 기여자와 맞춰 앞으로만 붙인다. #3621 @yansigit 처럼 “닫힘만 인정”한 건 trailer에 넣지 않았다. 구분이 맞다.

메인테이너의 판단이 필요한 지점

  • 이미 dev 에 들어간 문서 보정으로 끝낼지, 같은 3,000-커밋 창 밖에 남은 공백을 이어서 찾을지
  • 새 표의 “What landed” 칸을 더 짧은 직접 인용으로 맞출지, 지금처럼 클릭 가능한 요약 링크를 유지할지
  • [skip ci] 로 올라간 문서 PR을 앞으로 기본으로 둘지, 아니면 hygiene만 돌리고 나머지 CI는 생략할지

너의 추천
이미 dev 24c761a05 에 머지된 상태이니 추가 코드 변경은 하지 마세요. 문서-only forward repair이고, #1748 이름 오표기 같은 실제 공백을 고쳤으며, 옛 커밋·태그는 건드리지 않습니다. 다음에 할 일이 있다면 같은 감사 스크립트로 창 밖 공백만 더 찾고, 새 랜딩부터는 최종 squash 메시지의 Co-authored-by가 계정 noreply인지 확인하는 습관만 유지하면 됩니다. types/config 대분리로 닫을 PR은 아닙니다.

이 댓글은 grok-bot이 작성했습니다

lidge-jun added a commit that referenced this pull request Sep 6, 2026
…p ci]

docs(credits): record four-track contributor attribution [skip ci]

Record the original titles, authors and scoped landings of 12 carried PRs, plus eight issue-report acknowledgements. Confirm existing reachable human attribution and reinforce it with verified account-linked forward trailers. Preserve historical commits and tags.

The owner explicitly requested this documentation-only follow-up be merged into dev like #3787, without running or waiting for CI. No tests, typecheck or build were run.

Co-authored-by: ingwannu <186453546+Ingwannu@users.noreply.github.com>
Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>
Co-authored-by: SB Yoon <44089734+yansigit@users.noreply.github.com>
Co-authored-by: Siddarth Reddy <221318067+ideabib@users.noreply.github.com>
Co-authored-by: Hong Liu <88263959+Hylouis233@users.noreply.github.com>
Co-authored-by: Makhmeto <88025750+mashfromband@users.noreply.github.com>
Co-authored-by: Fred Amartey <43480311+FredAmartey@users.noreply.github.com>
Co-authored-by: WU, CHI-LUNG <215337896+chilung-cgu@users.noreply.github.com>
Co-authored-by: Amr Obaid <98298256+x3M3x@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant