feat(claude): gate lossy translated Messages with bounded diagnostics - #3806
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
d60a071 to
84c94f3
Compare
2489c67 to
7fb804a
Compare
리뷰 · 우선순위 52 / 80이 PR은 Track2 맨 위 층이다. 베이스는 현재 FEATURES 맵의 불리언 의미는 이름이 헷갈릴 수 있다. 주석대로 스택 관점에서는 #3803→#3805가 만든 Chat/refusal 기초 위에, Claude 번역 입구의 손실을 관측/차단하는 층이다. “새 provider 추가 없음” 방향과도 맞다. types/config에 필드 한두 줄이 더해지지만, 대규모 types/config split 캠페인에 삼켜질 규모는 아니다. close-don't-rebase 대상이 아니다. 최종 CI가 이 헤드( 운영 메모: 기본 off이므로 merge만으로 행동 변화는 거의 없다. shadow를 먼저 켜서 실트래픽 코드를 모은 뒤 enforce로 가는 순서를 문서에 적어 둔 것이 좋다. #3730 원본과 무엇이 달라졌는지도 merge 노트에 한 줄 있으면 기여자에게 친절하다. 경로 src/claude/compatibility.ts FEATURES - true=거절 대상, false=허용된 손실. 이름만 보면 isSupported처럼 보여 주석/문서에 의미를 더 밝혀 두면 좋다 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
…ity policy Reimplements PR #3730 from source head 18d6474 under the accepted track2 roadmap. Apply one policy before translation, retain only closed diagnostic codes, reject invalid configured modes, and persist shadow evidence through hydration. Validation: NOT RUN by explicit user instruction (no local tests, typecheck, build, install, prepush or live proxy). Parent owns test-layout registration, exact-head remote CI and independent implementation security review. Co-authored-by: SB Yoon <44089734+yansigit@users.noreply.github.com> Co-authored-by: Yumi <automation@sbyoon.com>
84c94f3 to
4255bfa
Compare
7fb804a to
14ee44b
Compare
Summary
Add an opt-in compatibility gate before translated Messages lose unsupported protocol semantics. Unset configuration preserves existing behavior; shadow records bounded evidence; enforce rejects the documented unsupported subset before inference. True native passthrough remains unchanged. Invalid configured modes return a fixed configuration error.
Use closed feature codes throughout request-log persistence and hydration. Document intentionally tolerated degradation instead of claiming lossless translation. Reimplements #3730 at source head 18d6474 with independent contract and security corrections.
Co-authored-by: SB Yoon 44089734+yansigit@users.noreply.github.com
Co-authored-by: Yumi automation@sbyoon.com
Verification
eff908e0f. Claude admission/persistence and diagnostic workflows received explicit independent security review. The Windows fixture changes also passed independent source review.--no-verify.4a759716a940595b999805be40d1514c100d63cf, containing all five layers plus deveff908e0f. All expected jobs completed successfully.f89b815090020f52089801b50f569a777bdfdc0a. Independent source interaction review passed. That track's 25-job CI verifies its own source; its initial watchdog failure remains recorded there.bf5ce1c3a0ada78f8e506334a82c64b525b859daadditionally passed remote Bun 1.4.0 typecheck, 541 tests across 11 relevant files, and the 425-page documentation build. This supplements the full cross-platform run at4a759716a; it is a focused combined-tree check, not a second complete platform matrix.Checklist
Manual review chain (integrate bottom-up)
devcodex/track2-protocol-foundationcodex/track2-canonical-effortscodex/track2-refusalcodex/track2-claude-compatibilityMaintainer integration decision: @lidge-jun explicitly integrates this PR into
devunder MAINTAINERS.md at head4255bfac615c59602088a9af5045762067d262c2, using the final-head-first verification above and the authorized admin merge. This is maintainer integration, not a self-approval. Lower skipped checks are not passing evidence. Actor, base, head and review state are refreshed before merging.Final integration path: #3803, #3804 and #3805 landed first. #3808 integrates the remaining Claude head and fixture repairs together. Its final history-only integration head is
9dc8988d79a29741de8a8b89bd52790c132d751e; treeeb4473dfe9e6b95072e3eb31901df635c73dd0ebexactly equals the remotely checked combined source. The full 25-job matrix is attributed to4a759716a, and combined-tree typecheck/541 tests/docs tobf5ce1c3a; no new full-platform run is claimed for the history-only head.Landing confirmed: included in dev
5759d9ea2f1e7281cdc01eb9628f2e0a123fb59c. All five PR heads are ancestors of fetched dev. Final treeeb4473dfe9e6b95072e3eb31901df635c73dd0ebexactly equals the remotely checked combined source. #3806 was integrated with #3808; GitHub records both as merged.