fix(codex): sustain and fence quota window activation - #3871
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (18)
📝 WalkthroughWalkthroughThe change strengthens Codex idle quota auto-activation. It preserves pending reset boundaries, refreshes stale metadata, publishes completed warmup headers, fences credential updates, handles rejected credentials, adds regression coverage, updates documentation, and adds Lane B release-train planning files. ChangesCodex quota activation
Lane B release-train planning
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant QuotaWorker
participant QuotaRefresh
participant Warmup
participant AccountState
QuotaWorker->>QuotaRefresh: Refresh stale quota metadata
QuotaWorker->>Warmup: Send activation warmup
Warmup-->>QuotaWorker: Return completed response headers
QuotaWorker->>AccountState: Persist quota and completion markers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 73 / 80이 PR은 #3856(terrytan95)을 핵심은 원본 #3856 리뷰에서 막았던 “영구 회귀 테스트 없음”도 이 캐리에서 메워졌습니다.
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
49f3a78 to
3955e10
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
cherry-pick -x, with follow-up main-account token preparation and credential-fenced completion handling. Closes bug(codex): automatic quota activation stalls after reset #3855.Verification
Local tests, typecheck, build, install and privacy scan: NOT RUN, explicitly prohibited by the maintainer's remote-only instruction.
git diff --check origin/dev HEAD: passed (source formatting only).Independent astra-high security implementation review (James): PASS, reviewed
458598f692aabf3cca11dc512b12a11b64dce265..49f3a78c56743442b503bf3f0e3645d638eb2a37. Main token preparation precedes WHAM shared ownership; synchronous identity, bearer/workspace and credential-generation checks fence header publication, late 401, and completion. Five new main-specific regression cases cover the findings.blocking_issues: []. This source-review verdict does not replace CI.Cross-platform CI: run 34110334640, pending cumulative top
b67f452c49904dbda2e0be435c2e34d5a064172f; only the top branch will dispatchci.ymlwithlane=all, including Windows shards. Lower commits intentionally use[skip ci].Rebased onto dev
d00615d5696a9c6b7f1a3006181e57569b012920after main-lane integration. All eight carried/follow-up patches are identical by range-diff; reviewed runtime/test files are byte-identical. PR fix(codex): sustain and fence quota window activation #3871 head:3955e10402dd12298a2fd6bf7cf9040daa02eb44; top fix(transport): admit canonical Mihomo IPv6 with validated pinning #3872 head:b67f452c49904dbda2e0be435c2e34d5a064172f.Manual chain (
stack: null; merge bottom-up after fresh cumulative-tree proof):Checklist
Co-authored-by: terrytan95 10609214+terrytan95@users.noreply.github.com
Maintainer integration decision (MAINTAINERS.md, dev-only admin integration): @lidge-jun integrates lane B's manual chain (#3871 → #3872) into
devbottom-up. Chain-top evidence at headb67f452c4: Cross-platform CI run 34111578200 — Linux test 1/4, 2/4, 4/4, macOS 1/2, 2/2, gates, storage policy, api usage, keyring ×3, npm-global ×3, docker smoke = success; test 3/4 failed only ontests/codex-integration/codex-prompt-text-probe.test.ts"admission stays occupied between child exit and close handling" (probe parent exit timeout under runner load; untouched by this chain and green at the same head in run 34110334640); Windows shards and macos control were deliberately cancelled — by maintainer instruction the Windows matrix and macos control run once on the final release-train head, not per chain. Prospective merge tree oforigin/dev@d00615d56+ top =58536270a= tested tree. Independent source/security review PASS per PR body. Local suites NOT RUN. This is maintainer integration, not self-approval.Summary by CodeRabbit
New Features
Bug Fixes
Documentation