feat(gui): edit subagent fallback and explain V2 compatibility - #3878
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1522f15 to
8f8ac0d
Compare
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 63 / 80이 PR은 #3252를 Lane C 5층(체인 top,
주의할 점: GUI 표면이 넓고, render 중 ref identity 재구성·포커스 복원 같은 섬세한 코드가 많아 리뷰·회귀 의존도가 큽니다. 스크린샷은 contributor 참고용이고 final V2 guidance 캡처는 top CI preview 후 교체 예정입니다. Lane C는 이 PR이 top이므로 아래층(3873–3876) CI·머지 순서에 묶입니다.
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
8f8ac0d to
18f1cdf
Compare
e2ad433 to
de5160f
Compare
18f1cdf to
16ac533
Compare
(cherry picked from commit 0f21769) Co-authored-by: RobinBially <7304732+RobinBially@users.noreply.github.com>
…p ci] Co-authored-by: RobinBially <7304732+RobinBially@users.noreply.github.com>
… ci] Co-authored-by: RobinBially <7304732+RobinBially@users.noreply.github.com>
(cherry picked from commit b0d86fa) Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
(cherry picked from commit aba57a0) Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
…atibility [skip ci] Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
… ci] Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
CI 34106956362 gates101697798420: remove render-time ref access and dynamic selector construction while preserving occurrence identity and keyboard focus. Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
de5160f to
abbdb22
Compare
16ac533 to
f1b8f2d
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b8f2d2f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Carry #3252 as an ordered fallback editor with its own Save and polling interval controls. Preserve unavailable configured targets, keep roster/fallback committed caches independent, block unknown legacy-cache writes, fence delayed reads and retain row identity/keyboard focus. Issue #1533 guidance uses existing /api/v2 mode/global/native-pin state, distinguishes native-parent encrypted tasks from readable routed-parent tasks, and honestly reports recovery activation/eligibility as unknown. No roster-reuse switch or runtime fallback-policy change is implemented or claimed.
Verification
f1b8f2d2f1edee55b68202469f86a5334710688d: Linux 4, macOS 2, gates, storage, API, all keyring/npm smokes and Docker. Overall run status iscompleted/success; this is not an assertion that every workflow job passed.macos controlto one run on the final release-train head. They are excluded only from this per-chain LANDABLE decision. Windows keyring/npm smoke jobs remain required. Lower product CI is represented by the cumulative top-head result.git diff --check: passed.Rendered from the remote CI dashboard artifact with isolated API fixtures; no live proxy settings changed. Artifact build-commit matched f1b8f2d and build-gui-tree matched 3b96491017e3e866e959aea62cab6790b034e101. Browser verified unavailable-model retention, reorder by click and Enter with focus retained, fallback Save feedback, and Desktop false-to-true preference. Screenshot viewport 1440x1013; additional 500px layout inspected. Local build/test/install not run.
Checklist
Manual dependent PR chain
Native stack:
null. Review only this layer’s diff. Main integrates bottom-up after refreshing dev ancestry, live heads/bases, review threads and required gates. This task does not merge. The CI-tested cumulative top tree is the integration target; advancing dev requires another cascade and top-head verification.51b44371860b2ec933d66de1b68ca790be3b81fb8eaa5641902b84bec6c97a94de6c2fe6d810c31d91b54b79bc780011031b00354621cc9fcaef360eabbdb227f385443228656c8440282187cb5dec75f1b8f2d2f1edee55b68202469f86a5334710688dCloses #1533. The underlying upstream protocol limitation #92 remains open.
Maintainer integration decision (MAINTAINERS.md, dev-only admin integration): @lidge-jun integrates lane C's manual chain (#3873 → #3874 → #3875 → #3876 → #3878) into
devbottom-up. Chain-top evidence at headf1b8f2d2f: Cross-platform CI run 34116228181, aggregateci= success (attempt 2: macos 1/2 timed out at 20 min in attempt 1 aftercodex-inject-write-lock.test.tswith no output; independent diagnosis found no causal link to this chain and the same head's macos control passed those tests; the failed job alone was rerun and passed — no code change). Windows 6/6 and macos control also green on this head. Prospective merge tree oforigin/dev@522ce5f8c+ top =e0b0e5886= tested tree. Independent source/security/GUI reviews PASS per PR bodies; screenshots from this run's dashboard-preview artifact. Local suites NOT RUN. Maintainer integration, not self-approval.