fix: preserve Pi session affinity through native Chat - #3880
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7220a7104
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a7220a7 to
5a462d3
Compare
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 65 / 80이 PR은 체인 두 번째입니다. base는 지금 이 PR은 세 곳을 맞춥니다. 첫째, 우선순위는 운영자 override → Codex 레인 → 클라이언트 fallback으로 테스트에 고정되어 있습니다. 악성/무관 destination으로 affinity 헤더가 새지 않는 테스트도 있습니다. 현재 types.ts/config.ts 대분할과 충돌하지 않습니다. 다만 base가 #3879이므로 #3879가 먼저 들어가야 하고, 원본 #3858은 캐리 합류 후 landed-via로 닫는 편이 맞습니다. 라인·경로 관찰에서 큰 버그는 보이지 않습니다.
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
f3cf20d to
075444c
Compare
722efdd to
f6359b8
Compare
…p ci] (cherry picked from commit 9bcb774) Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
…opies [skip ci] Thread live budgets through bridge and outbound callers, keep abnormal bridge cleanup on the typed overflow path, and retain only the constructed request body after serialization. Sync the authorized adapter and reference locale contracts. Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
… ci] (cherry picked from commit fbb214f) Co-authored-by: makesomethingshit <246213378+makesomethingshit@users.noreply.github.com> (cherry picked from commit 7e45a95f70689dfe1eb313c4af9aecbf2c44cdb6)
…kip ci] (cherry picked from commit 9f15a7c) Co-authored-by: makesomethingshit <246213378+makesomethingshit@users.noreply.github.com> (cherry picked from commit 65908008e52c5dca2eb1130d1c0cff0e0732873d)
(cherry picked from commit 23d8693) Co-authored-by: makesomethingshit <246213378+makesomethingshit@users.noreply.github.com> (cherry picked from commit 1e65ffd4bc9ba8befdf6e3546643b428106f4650)
Co-authored-by: makesomethingshit <246213378+makesomethingshit@users.noreply.github.com>
Co-authored-by: makesomethingshit <246213378+makesomethingshit@users.noreply.github.com>
f6359b8 to
d8b18b1
Compare
075444c to
feb1855
Compare
…pat flag [skip ci] Docs hunk from the lidge-jun#3858 carry (lidge-jun#3880) that lane A handed off because guides/providers.md is owned by the main lane in this train. Co-authored-by: makesomethingshit <246213378+makesomethingshit@users.noreply.github.com>
3 participants
Summary
Carries #3858 with original commit provenance. Pi configuration opts into affinity; native Chat, bridged Chat and Responses preserve the same canonical Go identity. Operator override precedes the Codex lane, which precedes fallback client metadata. Independent fixed vectors and distinct mixed-header fixtures pin hashing and precedence.
The source PR's checked local-CI boxes and stale blocked-readiness prose are not used as verification. This carry records actual remote evidence and explicit local NOT RUN. English and all7translated Pi guides now include the flag and cache-retention caveat; the M-owned providers.md hunk is supplied separately, including the Pi cacheRetention:none qualification; this layer does not modify that file.
Closes #3857.
Co-authored-by: makesomethingshit 246213378+makesomethingshit@users.noreply.github.com
Verification
git diff --check: PASS. All10Acommits compare=ingit range-diffafter rebasing ontoddee5e8b4e0535f3d99306b55f6ac4fb61c2d0ea; no conflicts.d4f0958225bb6bc64c707fbc9b9568fb567f9b9e.lane=all, exact topc84cc3b3e076b6c49cf93a6ca267f6303a698f5b.Checklist
Manual chain
Manual dependent PRs, native
stack: null; integrate bottom-up through the main session only.codex/260907-a-reasoningdevd8b18b1ecb013f46585c9e6dadac0b95caa49836codex/260907-a-affinitycodex/260907-a-reasoningfeb1855df91e5db351699d959d88d7e6c21c0f93codex/260907-a-compactcodex/260907-a-affinityc84cc3b3e076b6c49cf93a6ca267f6303a698f5bMaintainer integration is reserved for the main session under MAINTAINERS.md; this is not self-approval. This lane does not merge. Refresh dev, heads/bases, review threads, required gates and expected tree before integration; cascade and reverify if dev advances. The revised platform gate above is an explicit user decision for this lane, with deferred platform verification at final train head.
Independent review
Independent gpt-6-astra high explorer Avicenna: source/security PASS. Reviewed
d8b18b1ecb013f46585c9e6dadac0b95caa49836..feb1855df91e5db351699d959d88d7e6c21c0f93. All14affinity files unchanged; same patch ID after cascade. B quota opt-in/canonical checks and outbound TLS/address admission do not replace the Go affinity destination guard. A blockers0.This is an A-scoped source/security review, not blanket approval of the new base. Local tests/typecheck/build/install: NOT RUN.
VERDICT: PASS
Landing readiness
LANDABLE under the explicit updated lane policy. Exact-head Linux4, macOS2, gates, storage policy, API usage, all3keyring, all3npm-global and Docker jobs are SUCCESS. PR gates enforce-target/hygiene/label are SUCCESS, review findings resolved, and native stack is null. Final fetch confirmed dev
ddee5e8b4e0535f3d99306b55f6ac4fb61c2d0ea; expected cumulative merge tree equals tested top treed4f0958225bb6bc64c707fbc9b9568fb567f9b9e. Windows6/macOScontrol and full aggregate are not claimed green; deferred under user policy. No merge performed.Maintainer integration decision (MAINTAINERS.md, dev-only admin integration): @lidge-jun integrates lane A's manual chain (#3879 → #3880 → #3881) into
devbottom-up. Chain-top evidence at headc84cc3b3e: Cross-platform CI run 34113638182 — Linux test 1/4–4/4, macOS 1/2, 2/2, gates, storage policy, api usage, keyring ×3, npm-global ×3, docker smoke = success. Windows shards and macos control were cancelled by maintainer policy: they run once on the final release-train head. Prospective merge tree oforigin/dev@ddee5e8b4+ top =d4f095822= tested tree. Independent source/security reviews PASS per PR body; review threads resolved. Local suites NOT RUN. This is maintainer integration, not self-approval.