fix(ci): require non-empty bug Reproduction - #600
Conversation
Stop accepting bug reports that only fill Summary — empty or ellipsis-only Reproduction must fail the issue-quality gate (lidge-jun#598).
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughIssue validation now treats punctuation-only content as empty and provides field-specific diagnostics when bug reports lack Summary or Reproduction content. Tests cover blank, placeholder, and ellipsis-only inputs. ChangesIssue validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a133444fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const c = clean(text); | ||
| if (c.length === 0) return true; | ||
| // Stand-ins like "...", "…", "---" are not actionable report content. | ||
| return /^[\p{P}\p{S}\s]+$/u.test(c); |
There was a problem hiding this comment.
Restrict empty detection to known punctuation placeholders
This pattern classifies every punctuation- or symbol-only value as empty, not just stand-ins such as ... and ---. A concrete reproduction consisting of the problematic payload {}, [], /, or even an emoji is therefore rejected with Reproduction is empty; the enforcement path in .github/workflows/enforce-issue-quality.yml then closes the report. Match only known placeholder forms (such as ellipses or repeated dashes) rather than all Unicode punctuation and symbols.
Useful? React with 👍 / 👎.
Summary
.../…as empty so Open Codex Error #598-shaped reports cannot soft-pass with an ellipsis Reproduction.Test plan
node --test .github/scripts/issue-quality.test.cjs(86 pass)main, open a throwaway bug with Summary filled and Reproduction...and confirm Enforce issue quality closes itSummary by CodeRabbit
Bug Fixes
Tests