Skip to content

fix(ci): require non-empty bug Reproduction - #600

Merged
Wibias merged 1 commit into
lidge-jun:devfrom
Wibias:fix/issue-quality-require-reproduction
Jul 28, 2026
Merged

fix(ci): require non-empty bug Reproduction#600
Wibias merged 1 commit into
lidge-jun:devfrom
Wibias:fix/issue-quality-require-reproduction

Conversation

@Wibias

@Wibias Wibias commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • node --test .github/scripts/issue-quality.test.cjs (86 pass)
  • After merge + promote to main, open a throwaway bug with Summary filled and Reproduction ... and confirm Enforce issue quality closes it

Summary by CodeRabbit

  • Bug Fixes

    • Improved issue validation to recognize punctuation-only or placeholder content as empty.
    • Bug reports with missing summaries or reproduction steps now receive specific guidance identifying the incomplete section.
    • Enhanced validation for incomplete feature-request goals.
  • Tests

    • Added coverage for blank, placeholder, and punctuation-only bug report fields.
    • Updated validation tests to verify field-specific feedback.

Stop accepting bug reports that only fill Summary — empty or ellipsis-only Reproduction must fail the issue-quality gate (lidge-jun#598).
@github-actions github-actions Bot added the bug Something isn't working label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3da8765f-93c5-4503-a432-c095d85e123c

📥 Commits

Reviewing files that changed from the base of the PR and between 855ed7a and 9a13344.

📒 Files selected for processing (2)
  • .github/scripts/issue-quality.cjs
  • .github/scripts/issue-quality.test.cjs

📝 Walkthrough

Walkthrough

Issue validation now treats punctuation-only content as empty and provides field-specific diagnostics when bug reports lack Summary or Reproduction content. Tests cover blank, placeholder, and ellipsis-only inputs.

Changes

Issue validation

Layer / File(s) Summary
Broaden empty-content detection
.github/scripts/issue-quality.cjs:376-381, .github/scripts/issue-quality.test.cjs:365-366
isEmpty() now classifies cleaned punctuation, symbols, and whitespace as empty; feature validation assertions accept either “too vague” or “missing or empty” reasons.
Add field-specific bug validation
.github/scripts/issue-quality.cjs:648-658, .github/scripts/issue-quality.test.cjs:539-602
Bug validation emits separate guidance for missing Summary and Reproduction content, with tests covering blank, “No response”, and ellipsis-only values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: lidge-jun, ingwannu

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias merged commit ed5ddaf into lidge-jun:dev Jul 28, 2026
4 of 5 checks passed
@Wibias
Wibias deleted the fix/issue-quality-require-reproduction branch July 28, 2026 05:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a133444fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const c = clean(text);
if (c.length === 0) return true;
// Stand-ins like "...", "…", "---" are not actionable report content.
return /^[\p{P}\p{S}\s]+$/u.test(c);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict empty detection to known punctuation placeholders

This pattern classifies every punctuation- or symbol-only value as empty, not just stand-ins such as ... and ---. A concrete reproduction consisting of the problematic payload {}, [], /, or even an emoji is therefore rejected with Reproduction is empty; the enforcement path in .github/workflows/enforce-issue-quality.yml then closes the report. Match only known placeholder forms (such as ellipses or repeated dashes) rather than all Unicode punctuation and symbols.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant